Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inaccurate count when sorting by most viewed (resolves #238) #246

Merged
merged 6 commits into from
Mar 31, 2020

Conversation

greatislander
Copy link
Collaborator

Description

This PR resolves a bug which displayed an inaccurate resource count when sorting by most viewed.

Steps to test

  1. Sort by "Most Viewed".

Expected behavior: All resources our shown unless filters are applied.

Additional information

Not applicable.

Related issues

@greatislander greatislander added the enhancement New feature or request label Mar 31, 2020
@greatislander greatislander added this to the 1.0.0-rc.1 milestone Mar 31, 2020
@greatislander greatislander requested a review from jhung March 31, 2020 13:49
@greatislander greatislander self-assigned this Mar 31, 2020
jhung
jhung approved these changes Mar 31, 2020
@greatislander greatislander merged commit d361b12 into dev Mar 31, 2020
@greatislander greatislander deleted the fix/resource-count branch March 31, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting by most viewed shows inaccurate count
2 participants