Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting by most viewed shows inaccurate count #238

Closed
greatislander opened this issue Mar 28, 2020 · 0 comments · Fixed by #246
Closed

Sorting by most viewed shows inaccurate count #238

greatislander opened this issue Mar 28, 2020 · 0 comments · Fixed by #246
Assignees
@greatislander
Labels
bug Something isn't working
Milestone
1.0.0-rc.1

Comments

@greatislander
Copy link
Collaborator

Describe the bug
Sorting by most viewed shows that less than the total number of resources are being displayed.

To Reproduce
Steps to reproduce the behavior:

  1. Sort resources by most viewed.

Expected behavior
All resources are shown unless a filter is applied.

Screenshots
Not applicable.

Additional context
This is also related to the pre_get_posts filter.
@greatislander greatislander added the bug Something isn't working label Mar 28, 2020
@greatislander greatislander added this to the 1.0.0-rc.1 milestone Mar 28, 2020
@greatislander greatislander self-assigned this Mar 28, 2020
greatislander added a commit that referenced this issue Mar 31, 2020
@greatislander
fix: inaccurate count when sorting by most viewed (resolves #238)
f7262f2
@greatislander greatislander mentioned this issue Mar 31, 2020
Merged
2 tasks
greatislander pushed a commit that referenced this issue Mar 31, 2020
fix: inaccurate count when sorting by most viewed (resolves #238) (#246)
d361b12 
* fix: language filtering (resolves #237)

* fix: only show current language on front page

* fix: only show current language on front page

* fix: inaccurate count when sorting by most viewed (resolves #238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0-rc.1
Development

Successfully merging a pull request may close this issue.

fix: inaccurate count when sorting by most viewed (resolves #238) platform-coop-toolkit/coop-library
1 participant
@greatislander