Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve screen reader behaviour (fixes #131, fixes #200) #235

Merged
merged 2 commits into from
Mar 28, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Mar 28, 2020

Description

Adds screen reader feedback when a "Deselect all" button is clicked in the filter list. Announces notifications when they are added to the DOM.

Steps to test

  1. Enable a screen reader (NVDA or VoiceOver).
  2. Check some topics on the Browse All page's filter list.
  3. Click the "Deselect all" button under topics.
  4. Test all behaviours which display notifications (saving/removing saved searches, saving/removing favorites).

Expected behavior: "All topics have been deselected" is announced to screen reader users.

Additional information

Implemented using the @wordpress/a11y "speak" utility.

Related issues

@greatislander greatislander added the enhancement New feature or request label Mar 28, 2020
@greatislander greatislander added this to the 1.0.0-rc.1 milestone Mar 28, 2020
@greatislander greatislander requested a review from jhung March 28, 2020 15:35
@greatislander greatislander self-assigned this Mar 28, 2020
@greatislander greatislander changed the title fix: add screen reader feedback for deselect all button (resolves #131) fix: improve screen reader behaviour (fixes #131, fixes #200) Mar 28, 2020
@greatislander greatislander merged commit c9147b7 into dev Mar 28, 2020
@greatislander greatislander deleted the add/deselect-all-notice branch March 28, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant