Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification with role="alert" is not announced after performing an action in a dialog #200

Closed
jhung opened this issue Feb 28, 2020 · 2 comments · Fixed by #235
Closed
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@jhung
Copy link
Contributor

jhung commented Feb 28, 2020

Describe the bug
After performing an action in a dialog, the notification that appears confirming the action is not read back by the screen reader. Currently this can be seen with actions related to saved searches: saving a search, and deleting a saved search.

Tested with NVDA.

To Reproduce
Steps to reproduce the behavior:

  1. Perform a search
  2. Turn on a screen reader (i.e. NVDA)
  3. Select "Save my search"
  4. Select "Save"
  5. Notice that the notification is not read back by the screen reader.

Expected behavior
After performing an action in a dialog, the notification should be read back with the screen reader.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Firefox + NVDA
@jhung jhung added the bug Something isn't working label Feb 28, 2020
@jhung
Copy link
Contributor Author

jhung commented Feb 28, 2020

Could not confirm whether this happens in Pinecone as the Search Results layout does not produce a notification.

Also, could it be that the notification is being added to the document while it is inert? Perhaps removing inert before adding the notification will trigger the desired response from the screen reader.

@greatislander greatislander added this to the 1.0.0-alpha.2 milestone Mar 5, 2020
@greatislander greatislander self-assigned this Mar 5, 2020
@greatislander
Copy link
Collaborator

Hi @jhung, I can't reproduce this in Safari/VoiceOver. The notification has role="alert". Do you know if NVDA needs aria-live as well to read elements added to the DOM? The notification is not being added to the DOM while it's inert (or at any rate it's not preventing VoiceOver from properly announcing it).

@greatislander greatislander changed the title Notifications with role=Alert is not announced after performing an action in a dialog Notification with role="alert" is not announced after performing an action in a dialog Mar 11, 2020
@greatislander greatislander added the help wanted Extra attention is needed label Mar 11, 2020
greatislander pushed a commit that referenced this issue Mar 28, 2020
* fix: add screen reader feedback for deselect all button (fix #131)
* fix: announce notifications (resolves #200)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants