Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove favorite from page after deletion (fix #220) #221

Merged
merged 2 commits into from
Mar 11, 2020
Merged

fix: remove favorite from page after deletion (fix #220) #221

merged 2 commits into from
Mar 11, 2020

Conversation

greatislander
Copy link
Collaborator

Description

Fixes #220.

Steps to test

  1. Add some favorites.
  2. Visit favorites page.
  3. Delete a favorite.

Expected behavior: Favorite card is removed.

Additional information

Not applicable.

Related issues

@greatislander greatislander added the bug Something isn't working label Mar 11, 2020
@greatislander greatislander added this to the 1.0.0-alpha.2 milestone Mar 11, 2020
@greatislander greatislander requested a review from jhung March 11, 2020 15:53
@greatislander greatislander self-assigned this Mar 11, 2020
@greatislander greatislander merged commit 5b3f9e5 into dev Mar 11, 2020
@greatislander greatislander deleted the fix/favorite-deletion branch March 11, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhung jhung jhung approved these changes

Assignees

@greatislander greatislander

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0-alpha.2
Development

Successfully merging this pull request may close these issues.

Deleted Favorite visible after deletion
2 participants
@greatislander @jhung