Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted Favorite visible after deletion #220

Closed
jhung opened this issue Mar 11, 2020 · 0 comments · Fixed by #221
Closed

Deleted Favorite visible after deletion #220

jhung opened this issue Mar 11, 2020 · 0 comments · Fixed by #221
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jhung
Copy link
Contributor

jhung commented Mar 11, 2020

Describe the bug
After deleting a Favorite from the list, the resource is still visible.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Favorites page.
  2. Remove a resource from the list.
  3. Notice that the resource is still there, but the Remove icon is missing for it.

Expected behavior
One of two things should happen when a resource is removed from Favorites:

  • The resource should disappear from the list.
  • The resource can remain, but with an indicator that it's been removed from favourites, and the "(Heart) Favorited" removed. In this case, there may be an expectation for an "undo remove from favorites" function.

Screenshots

In the screenshot below, "Why You Should Read 'Ours to hack and to own" has been removed, but still visible.
image

@jhung jhung added the bug Something isn't working label Mar 11, 2020
@greatislander greatislander self-assigned this Mar 11, 2020
@greatislander greatislander added this to the 1.0.0-alpha.2 milestone Mar 11, 2020
greatislander added a commit that referenced this issue Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants