Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved searches can exceed the 50 search limit #206

Closed
jhung opened this issue Mar 2, 2020 · 0 comments · Fixed by #212
Closed

Saved searches can exceed the 50 search limit #206

jhung opened this issue Mar 2, 2020 · 0 comments · Fixed by #212
Assignees
@greatislander
Labels
bug Something isn't working
Milestone
1.0.0-alpha.2

Comments

@jhung
Copy link
Contributor

jhung commented Mar 2, 2020

Describe the bug
It is possible to save more than 50 saved searches.

To Reproduce
Steps to reproduce the behavior:

  1. Search for a resource.
  2. Repeatedly select "Save my search" it until there are more than 50 saved searches.
  3. Notice how it's possible to have more than 50 saved searches, and the notification reports a negative number.

Expected behavior
User should only be able to save 50 searches (or whatever limit is set).

Screenshots

If applicable, add screenshots to help explain your problem.
image
@jhung jhung added the bug Something isn't working label Mar 2, 2020
@greatislander greatislander self-assigned this Mar 5, 2020
@greatislander greatislander added this to the 1.0.0-alpha.2 milestone Mar 5, 2020
greatislander added a commit that referenced this issue Mar 5, 2020
@greatislander
fix: don't allow searches to be saved when limit is reached
066deb1 
Resolves #206
@greatislander greatislander mentioned this issue Mar 5, 2020
Merged
2 tasks
greatislander pushed a commit that referenced this issue Mar 10, 2020
fix: don't allow saved searches over limit (resolves #206) (#212)
dccd6c6 
* fix: don't allow searches to be saved when limit is reached

Resolves #206

* fix: adjust title of notification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0-alpha.2
Development

Successfully merging a pull request may close this issue.

fix: don't allow saved searches over limit (resolves #206) platform-coop-toolkit/coop-library
2 participants
@jhung @greatislander