Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fallback icons for new formats (resolves #169) #170

Merged
merged 2 commits into from
Jan 29, 2020

Conversation

greatislander
Copy link
Collaborator

Description

This PR assigns icons to all new formats.

Steps to test

  1. Visit home page/browse all resources page.

Expected behavior: All resources load with an icon assigned.

Additional information

We will need to design new icons for some of the formats; however, this fix will prevent errors when accessing the development and staging sites in the interim.

Related issues

@greatislander greatislander self-assigned this Jan 29, 2020
@greatislander greatislander added the bug Something isn't working label Jan 29, 2020
@greatislander greatislander added this to the 1.0.0-alpha.2 milestone Jan 29, 2020
@greatislander greatislander merged commit 66916fc into dev Jan 29, 2020
@greatislander greatislander deleted the fix/icon-error branch January 29, 2020 17:41
@greatislander greatislander mentioned this pull request Jan 30, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing icons for newly-added formats causes a critical error
1 participant