Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing icons for newly-added formats causes a critical error #169

Closed
greatislander opened this issue Jan 29, 2020 · 0 comments · Fixed by #170
Closed

Missing icons for newly-added formats causes a critical error #169

greatislander opened this issue Jan 29, 2020 · 0 comments · Fixed by #170
Assignees
@greatislander @cherylhjli
Labels
bug Something isn't working needs-design This feature depends on designs
Milestone
1.0.0-alpha.2

Comments

@greatislander
Copy link
Collaborator

greatislander commented Jan 29, 2020 •
edited
Loading

Describe the bug
There are a number of new formats. We don't have icons for all of them, and the SVG loader throws a fatal error when trying to include an icon that doesn't exist.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://stage.commons.platform.coop/en/resources.
  2. Observe critical error message..

Expected behavior
Resource page loads.

Screenshots
Not applicable.

Additional context

PHP Fatal error:  Uncaught Illuminate\Contracts\Filesystem\FileNotFoundException:
File does not exist at path .../wp-content/themes/coop-library/dist/images/blog-post.svg in .../wp-content/themes/coop-library/vendor/illuminate/filesystem/Filesystem.php:41

For now, we can assign a generic icon to all formats which don't have an icon yet. Eventually, we'll need more icons.
@greatislander greatislander added the bug Something isn't working label Jan 29, 2020
@greatislander greatislander self-assigned this Jan 29, 2020
@greatislander greatislander added this to the 1.0.0-alpha.2 milestone Jan 29, 2020
@greatislander greatislander added the needs-design This feature depends on designs label Jan 29, 2020
greatislander added a commit that referenced this issue Jan 29, 2020
@greatislander
fix: add fallback icons for new formats (fix #169)
f0c3b4a
@greatislander greatislander mentioned this issue Jan 29, 2020
Merged
2 tasks
greatislander pushed a commit that referenced this issue Jan 29, 2020
fix: add fallback icons for new formats (resolves #169) (#170)
66916fc 
* fix: add fallback icons for new formats (fix #169)
* fix: adjust presentation slides slug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

@cherylhjli cherylhjli

Labels
bug Something isn't working needs-design This feature depends on designs
Projects
None yet
Milestone
1.0.0-alpha.2
Development

Successfully merging a pull request may close this issue.

fix: add fallback icons for new formats (resolves #169) platform-coop-toolkit/coop-library
2 participants
@greatislander @cherylhjli