Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add favorites management #111

Closed
greatislander opened this issue Jan 10, 2020 · 0 comments · Fixed by #163
Closed

Add favorites management #111

greatislander opened this issue Jan 10, 2020 · 0 comments · Fixed by #163
Assignees
@greatislander
Labels
enhancement New feature or request
Milestone
1.0.0-alpha.2

Comments

@greatislander
Copy link
Collaborator

greatislander commented Jan 10, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.

Users should be able to add a resource to a locally-stored favorites list, and view and manage these favorites from a dedicated page.https://github.com/platform-coop-toolkit/coop-library/issues/new/choose

Describe the solution you'd like

See wires in Figma and XD, as well as reference implementation of local storage in pwa-experiments.netlify.com.

Describe alternatives you've considered

Not applicable.

Additional context

Not applicable.
@greatislander greatislander self-assigned this Jan 10, 2020
@greatislander greatislander added the enhancement New feature or request label Jan 10, 2020
@greatislander greatislander added this to the 1.0.0-alpha.1 milestone Jan 10, 2020
@greatislander greatislander changed the title Favorites management Add favorites management Jan 13, 2020
@greatislander greatislander mentioned this issue Jan 22, 2020
Merged
2 tasks
This was referenced Jan 24, 2020
Merged
Merged
greatislander pushed a commit that referenced this issue Feb 14, 2020
feat: add favorites management (fixes #111) (#163)
a7d61ae 
* feat: add client-side favorite management

* feat: switch icon

* feat: load resources via WP API on favorites page

* feat: use cookies instead of localStorage to allow server-side retrieval

* feat: add AJAX backend to update resource favorite counts

* chore(deps): bump @platform-coop-toolkit/pinecone to 1.0.0-alpha.9

* feat: add filled favorite icon

* feat: allow removal of favorites from favorites page

* chore(docs): add TODO comment

* feat: use new format icons

* feat: check for cookies

* feat: implement many changes from Pinecone

* fix: add @wordpress/i18n

* feat: add remove all capability

* fix: remove extraneous Card initializations

* feat: add notifications to favorites page

* feat: add notices to single resource page

* fix: menu script

* fix: use new pagination markup

* fix: use new pagination markup

* fix: remove redundant roles to prevent duplicate announcements

* feat: make notifications sticky

* feat: temporary styling, prevent stacked notifications

* feat: clean up styles to match platform-coop-toolkit/pinecone#242

* fix: add alert role to notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0-alpha.2
Development

Successfully merging a pull request may close this issue.

feat: add favorites management (fixes #111) platform-coop-toolkit/coop-library
1 participant
@greatislander