fix: only enqueue editor scripts on editor screen

assets/js/admin/admin.js

@@ -1,114 +0,0 @@
-/* global acf */
-
-const { __, sprintf } = wp.i18n;
-const { speak } = wp.a11y;
-const daysInMonth = require( 'days-in-month' );
-
-jQuery( document ).ready( function( $ ) {
-	const yearField = acf.getField( 'field_5e56ee8953584' );
-	const monthField = acf.getField( 'field_5e56eef559a76' );
-	const dayField = acf.getField( 'field_5e56f04ee5a20' );
-
-	/**
-	 * Populate options for the publication day field that are appropriate
-	 * to the selected year and month.
-	 */
-	const setupDays = () => {
-		const year = yearField.val();
-		const month = monthField.val();
-		if ( year && month ) {
-			const day = dayField.val();
-			const daySelect = $( `#acf-${dayField.data.key}` );
-			const dayCount = daysInMonth( year, month );
-			if ( day > dayCount ) {
-				const errorText = sprintf( __( 'The publication day has been reset as there are only %1$d days in the selected month, and your choice of %2$d is no longer valid.', 'coop-library-framework' ), dayCount, day );
-				dayField.showNotice( {
-					text: errorText,
-					type: 'warning',
-					dismiss: true,
-				} );
-				speak( errorText );
-			}
-			daySelect.children().not( '[value=""]' ).remove();
-			for ( let i = 1; i < dayCount + 1; i++ ) {
-				const option = document.createElement( 'option' );
-				const val = 9 > i ? `0${i}` : i;
-				option.setAttribute( 'value', val );
-				option.innerText = i;
-				daySelect.append( option );
-			}
-			if ( day ) {
-				dayField.val( day );
-			}
-		}
-	};
-
-	yearField.on( 'change', setupDays );
-	monthField.on( 'change', setupDays );
-
-	const $form = $( '#post' );
-	const $titleRow = $( '#titlewrap' );
-
-	/**
-	 * Validate the form.
-	 *
-	 * @param {Event} event
-	 */
-	function validateForm( event ) {
-		const $errorFields = [];
-		let $firstError = null;
-		$( '.error' ).remove();
-
-		/**
-		 * Add required flag to a form row.
-		 *
-		 * @param {jQuery} $row
-		 */
-		function addRequiredError( $row ) {
-			const $label = $row.find( 'label' );
-			const labelText = $label.text().replace( 'Add title', 'Title' );
-			$errorFields.push(
-				{ id: $label.attr( 'for' ), label: labelText, type: 'required' }
-			);
-			$row.addClass( 'form-invalid' );
-			/* translators: %s: The label of the required field. */
-			const errorText = sprintf( __( 'A %s is required.', 'coop-library-framework' ), labelText.toLowerCase() );
-			const error = $( `<p class="error">${errorText}</p>` );
-			$row.append( error );
-			$firstError = $firstError ? $firstError : $row;
-		}
-
-		if ( 0 === $titleRow.children( 'input' ).val().length ) {
-			addRequiredError( $titleRow );
-		}
-
-		if ( $firstError ) {
-			event.preventDefault();
-			$( '#validation-message' ).remove();
-			const errorMessage = __( 'The form contains errors:', 'coop-library-framework' );
-			const errorList = $errorFields.reduce( ( html, field, index ) => {
-				let errorText;
-				if ( 'required' === field.type ) {
-					/* translators: %s: The label of the required field. */
-					errorText = sprintf( __( 'A %s is required.', 'coop-library-framework' ), field.label.toLowerCase() );
-				}
-				if ( 0 < index ) {
-					return `${html}<li><a href="#${field.id}">${errorText}</a></li>`;
-				} else {
-					return `<li><a href="#${field.id}">${errorText}</a></li>`;
-				}
-			}, $errorFields[0] );
-			const errorContainer = $( '<div role="alert"></div>' );
-			const error = $(
-				`<div id="validation-message" class="notice notice-error">
-					<p>${errorMessage}</p>
-					<ul>${errorList}</ul>
-				</div>` );
-			$( '.wp-header-end' ).after( errorContainer );
-			$( errorContainer ).append( error );
-		}
-		return true;
-	}
-
-	$form.on( 'submit', validateForm );
-} );

assets/js/editor/editor.js

@@ -0,0 +1,114 @@
+/* global acf */
+
+const { __, sprintf } = wp.i18n;
+const { speak } = wp.a11y;
+const daysInMonth = require( 'days-in-month' );
+
+jQuery( document ).ready( function( $ ) {
+	const yearField = acf.getField( 'field_5e56ee8953584' );
+	const monthField = acf.getField( 'field_5e56eef559a76' );
+	const dayField = acf.getField( 'field_5e56f04ee5a20' );
+
+	/**
+	 * Populate options for the publication day field that are appropriate
+	 * to the selected year and month.
+	 */
+	const setupDays = () => {
+		const year = yearField.val();
+		const month = monthField.val();
+		if ( year && month ) {
+			const day = dayField.val();
+			const daySelect = $( `#acf-${dayField.data.key}` );
+			const dayCount = daysInMonth( year, month );
+			if ( day > dayCount ) {
+				const errorText = sprintf( __( 'The publication day has been reset as there are only %1$d days in the selected month, and your choice of %2$d is no longer valid.', 'coop-library-framework' ), dayCount, day );
+				dayField.showNotice( {
+					text: errorText,
+					type: 'warning',
+					dismiss: true,
+				} );
+				speak( errorText );
+			}
+			daySelect.children().not( '[value=""]' ).remove();
+			for ( let i = 1; i < dayCount + 1; i++ ) {
+				const option = document.createElement( 'option' );
+				const val = 9 > i ? `0${i}` : i;
+				option.setAttribute( 'value', val );
+				option.innerText = i;
+				daySelect.append( option );
+			}
+			if ( day ) {
+				dayField.val( day );
+			}
+		}
+	};
+
+	yearField.on( 'change', setupDays );
+	monthField.on( 'change', setupDays );
+
+	const $form = $( '#post' );
+	const $titleRow = $( '#titlewrap' );
+
+	/**
+	 * Validate the form.
+	 *
+	 * @param {Event} event
+	 */
+	function validateForm( event ) {
+		const $errorFields = [];
+		let $firstError = null;
+		$( '.error' ).remove();
+
+		/**
+		 * Add required flag to a form row.
+		 *
+		 * @param {jQuery} $row
+		 */
+		function addRequiredError( $row ) {
+			const $label = $row.find( 'label' );
+			const labelText = $label.text().replace( 'Add title', 'Title' );
+			$errorFields.push(
+				{ id: $label.attr( 'for' ), label: labelText, type: 'required' }
+			);
+			$row.addClass( 'form-invalid' );
+			/* translators: %s: The label of the required field. */
+			const errorText = sprintf( __( 'A %s is required.', 'coop-library-framework' ), labelText.toLowerCase() );
+			const error = $( `<p class="error">${errorText}</p>` );
+			$row.append( error );
+			$firstError = $firstError ? $firstError : $row;
+		}
+
+		if ( 0 === $titleRow.children( 'input' ).val().length ) {
+			addRequiredError( $titleRow );
+		}
+
+		if ( $firstError ) {
+			event.preventDefault();
+			$( '#validation-message' ).remove();
+			const errorMessage = __( 'The form contains errors:', 'coop-library-framework' );
+			const errorList = $errorFields.reduce( ( html, field, index ) => {
+				let errorText;
+				if ( 'required' === field.type ) {
+					/* translators: %s: The label of the required field. */
+					errorText = sprintf( __( 'A %s is required.', 'coop-library-framework' ), field.label.toLowerCase() );
+				}
+				if ( 0 < index ) {
+					return `${html}<li><a href="#${field.id}">${errorText}</a></li>`;
+				} else {
+					return `<li><a href="#${field.id}">${errorText}</a></li>`;
+				}
+			}, $errorFields[0] );
+			const errorContainer = $( '<div role="alert"></div>' );
+			const error = $(
+				`<div id="validation-message" class="notice notice-error">
+					<p>${errorMessage}</p>
+					<ul>${errorList}</ul>
+				</div>` );
+			$( '.wp-header-end' ).after( errorContainer );
+			$( errorContainer ).append( error );
+		}
+		return true;
+	}
+
+	$form.on( 'submit', validateForm );
+} );

config/webpack.common.js

@@ -1,5 +1,3 @@
-/* global process, module, require */
-
 const path = require( 'path' );
 const CleanWebpackPlugin = require( 'clean-webpack-plugin' );
 const CopyWebpackPlugin = require( 'copy-webpack-plugin' );

config/webpack.dev.js

@@ -1,5 +1,3 @@
-/* global module, require */
-
 const merge = require( 'webpack-merge' );
 const common = require( './webpack.common.js' );
 const BrowserSyncPlugin = require( 'browser-sync-webpack-plugin' );

config/webpack.prod.js

@@ -1,5 +1,3 @@
-/* global module, require */
-
 const merge = require( 'webpack-merge' );
 const common = require( './webpack.common.js' );
 const TerserPlugin = require( 'terser-webpack-plugin' );

config/webpack.settings.js

@@ -1,10 +1,9 @@
-/* global module */
-
 // Webpack settings exports.
 module.exports = {
 	entries: {
 		// JS files.
 		'admin': './assets/js/admin/admin.js',
+		'editor': './assets/js/editor/editor.js',
 		'frontend': './assets/js/frontend/frontend.js',
 		'shared': './assets/js/shared/shared.js',
 

includes/functions/core.php

@@ -78,7 +78,7 @@ function resource_init() {
 		array(
 			'admin_cols'          => [
 				'title',
-				'resource-language'  => [
+				'resource-language' => [
 					'title'    => __( 'Resource Language', 'coop-library-framework' ),
 					'meta_key' => 'language',
 					'function' => function() {
@@ -89,19 +89,19 @@ function resource_init() {
 					'title'    => __( 'Display Language', 'coop-library-framework' ),
 					'taxonomy' => 'language',
 				],
-				'format'    => [
+				'format'            => [
 					'title'    => __( 'Format', 'coop-library-framework' ),
 					'taxonomy' => 'lc_format',
 				],
-				'topic'     => [
+				'topic'             => [
 					'title'    => __( 'Topics', 'coop-library-framework' ),
 					'taxonomy' => 'lc_topic',
 				],
-				'published' => [
+				'published'         => [
 					'title'    => __( 'Date Published', 'coop-library-framework' ),
 					'meta_key' => 'lc_resource_publication_date',
 				],
-				'added'     => [
+				'added'             => [
 					'title'      => __( 'Date Added', 'coop-library-framework' ),
 					'post_field' => 'post_date',
 					'default'    => 'DESC',
@@ -593,7 +593,7 @@ function deactivate() {
  * @return array
  */
 function get_enqueue_contexts() {
-	return [ 'admin', 'frontend', 'shared' ];
+	return [ 'admin', 'editor', 'frontend', 'shared' ];
 }
 
 /**
@@ -655,9 +655,11 @@ function scripts() {
 /**
  * Enqueue scripts for admin.
  *
+ * @param string $hook_suffix The suffix for the current page.
+ *
  * @return void
  */
-function admin_scripts() {
+function admin_scripts( $hook_suffix ) {
 	wp_enqueue_script(
 		'coop_library_framework_shared',
 		script_url( 'shared', 'shared' ),
@@ -669,10 +671,26 @@ function admin_scripts() {
 	wp_enqueue_script(
 		'coop_library_framework_admin',
 		script_url( 'admin', 'admin' ),
-		[ 'wp-a11y', 'wp-i18n' ],
+		[],
 		COOP_LIBRARY_FRAMEWORK_VERSION,
 		true
 	);
+
+	$cpt = 'lc_resource';
+
+	if ( in_array( $hook_suffix, array( 'post.php', 'post-new.php' ), true ) ) {
+		$screen = get_current_screen();
+
+		if ( is_object( $screen ) && $cpt === $screen->post_type ) {
+			wp_enqueue_script(
+				'coop_library_framework_editor',
+				script_url( 'editor', 'editor' ),
+				[ 'wp-a11y', 'wp-i18n' ],
+				COOP_LIBRARY_FRAMEWORK_VERSION,
+				true
+			);
+		}
+	}
 }
 
 /**

includes/functions/internationalization.php

@@ -16,28 +16,6 @@ function setup() {
 	$n = function( $function ) {
 		return __NAMESPACE__ . "\\$function";
 	};
-
-	add_filter( 'pll_copy_post_metas', $n( 'copy_post_metas' ) );
-}
-
-/**
- * Determine which post meta should be synchronized between translations.
- *
- * @param array $metas The array of metadata keys to synchronize.
- */
-function copy_post_metas( $metas ) {
-	$unset = [
-		// Link will differ for the translated version.
-		'lc_resource_permanent_link',
-		// Translator will be specific to the translated version.
-		'lc_resource_translator',
-	];
-	foreach ( $metas as $key => $value ) {
-		if ( in_array( $value, $unset, true ) ) {
-			unset( $metas[ $key ] );
-		}
-	}
-	return $metas;
 }
 
 /**

tests/phpunit/test-tools/Internationalization_Tests.php

@@ -9,15 +9,6 @@ class Internationalization_Tests extends Base\TestCase {
 		'functions/internationalization.php'
 	];
 
-	public function test_copy_post_metas() {
-		$meta_keys_to_copy = copy_post_metas( [
-			0 => 'lc_resource_permanent_link',
-			1 => 'lc_resource_publisher_name',
-		] );
-
-		$this->assertNotContains( 'lc_resource_permanent_link', $meta_keys_to_copy );
-	}
-
 	public function test_get_country_list() {
 		$countries_de = get_country_list( 'de_DE' );
 		$this->assertEquals( $countries_de['CA'], 'Kanada' );