Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only enqueue editor scripts on editor screen #337

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

greatislander
Copy link
Collaborator

Description

Enqueuing the editor JavaScript was causing a console error on other admin screens. This PR moves the editor JavaScript to its own file which is only enqueued on new and existing resource editor screens.

Steps to test

  1. Visit any admin screen.

Expected behavior: There should be no console errors.

Additional information

Not applicable.

Related issues

Not applicable.

Fix PHPCS errors
Sync all post meta
@greatislander greatislander added the bug Something isn't working label Apr 1, 2020
@greatislander greatislander added this to the 1.0.0-rc.2 milestone Apr 1, 2020
@greatislander greatislander requested a review from jhung April 1, 2020 13:55
@greatislander greatislander self-assigned this Apr 1, 2020
@greatislander greatislander merged commit dbd3b6f into dev Apr 1, 2020
@greatislander greatislander deleted the fix/admin-scripts branch April 1, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants