Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect plugin order in config.rb #8

Merged
merged 1 commit into from
Dec 31, 2013
Merged

Respect plugin order in config.rb #8

merged 1 commit into from
Dec 31, 2013

Conversation

jeffutter
Copy link

after_build should be inside after_config to respect order of plugins in config.rb. Without this images generated by other plugins (such as thumbnailer) don't get optimized because imageoptim is registered before those are run.

There is a similar issue discussed here:
http://forum.middlemanapp.com/t/order-of-after-build-callbacks/901/6

@plasticine
Copy link
Owner

Awesome, looks good. Thanks very much. Will merge and get a new release out in the next day-or-so.

plasticine added a commit that referenced this pull request Dec 31, 2013
Respect plugin order in config.rb
@plasticine plasticine merged commit dea2252 into plasticine:master Dec 31, 2013
@jeffutter
Copy link
Author

Could you cut a new gem release soon-ish? Thanks!

@plasticine
Copy link
Owner

Done. Apologies for the delay. 💃

@jeffutter jeffutter deleted the build-after-config branch January 28, 2014 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants