Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Pbd code, start of lldb w/ same way to do conversations. #34

Merged
merged 11 commits into from
Feb 19, 2024

Conversation

stephenfreund
Copy link
Contributor

No description provided.

Copy link
Collaborator

@nicovank nicovank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

test/a.out Outdated Show resolved Hide resolved
test/python/README.md Show resolved Hide resolved

import llm_utils
from openai import *
from pydantic import BaseModel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add pydantic to the pyproject.toml:

dependencies = ["llm_utils>=0.2.6", "openai>=1.6.1", "rich>=13.7.0"]

Copy link
Collaborator

@nicovank nicovank Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless it's not used, which may be the case here from a quick search, then just remove import 👍 .

EDIT: It is used.

Copy link
Collaborator

@nicovank nicovank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just going to go ahead and merge this. @ravenblood000 and I need this in to continue as changes are pretty significant. It's also getting too large for me to keep track of, I think we should have separated and merged prior to the IPDB stuff.

image

I'll merge and address a couple of things.

.gitignore Show resolved Hide resolved
@@ -6,6 +6,8 @@

sys.path.insert(0, os.path.abspath(the_path))

from . import chatdbg
from .chatdbg import *
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really not a fan of import *. It can shadow existing imports/variables silently and heavily messes with any static analysis tool (not that we have any currently). I'll just fix it after this merges.

test/a.out Show resolved Hide resolved
src/chatdbg/chatdbg_ipdb.py Show resolved Hide resolved
src/chatdbg/chatdbg_ipdb.py Show resolved Hide resolved
@nicovank nicovank merged commit 8c6044e into plasma-umass:main Feb 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants