-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Pbd code, start of lldb w/ same way to do conversations. #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
|
||
import llm_utils | ||
from openai import * | ||
from pydantic import BaseModel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add pydantic
to the pyproject.toml
:
Line 11 in 4d3997b
dependencies = ["llm_utils>=0.2.6", "openai>=1.6.1", "rich>=13.7.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless it's not used, which may be the case here from a quick search, then just remove import 👍 .
EDIT: It is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -6,6 +6,8 @@ | |||
|
|||
sys.path.insert(0, os.path.abspath(the_path)) | |||
|
|||
from . import chatdbg | |||
from .chatdbg import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am really not a fan of import *
. It can shadow existing imports/variables silently and heavily messes with any static analysis tool (not that we have any currently). I'll just fix it after this merges.
No description provided.