Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence diagram text misalignment for self-reference/left side/within group #839

Closed
c-george opened this issue Dec 22, 2021 · 7 comments
Closed

Comments

@c-george
Copy link

For:

  • PlantUML v2.17.0 (within VSCode extension, if that matters)
  • sequence diagram

When:

  • participant message to self
  • within a group bounding box
  • with left-facing arrow

Erroneous Result:

  • group bounding box is rendered as if text were being rendered with right-facing arrow
  • bounding box appears to be correct size, just in the wrong horizontal location

Sample Code:

@startuml

group
    a -> a : This works fine
end

group
    a <- a : This does not work
end

@enduml`
@The-Lum
Copy link
Collaborator

The-Lum commented Dec 22, 2021

Hello @c-george and all,

From:

@startuml
group
    a -> a : This works fine
end
group
    a <- a : This does not work
end
@enduml

Here is the corresponding image:

Here is a possible workaround, with adding an hidden arrow:

@startuml
group
    a -> a : This works fine
end
group
    a <- a : This does work, but too big
    [<[hidden]- a
end
@enduml

If that can help,
Regards.

@c-george
Copy link
Author

Thanks @The-Lum. I truly appreciate your suggestion (and how quickly it came). It will help make my diagram a little bit prettier. Fortunately this issue is minor for me and isn't causing me any grief.

I should also take the time to thank all the developers of this incredible piece of software (PlantUML)! I've been using it quite a bit for about 4 years with no significant problems. I find this level of usability to be very rare for any piece of software, and it is a true testament to the talents and dedication of all those involved!

@The-Lum
Copy link
Collaborator

The-Lum commented Dec 22, 2021

Thanks a lot.
I am just a fan user...

All the congratulations can go to the PlantUML team and @arnaudroques, (and all the contributors):

I should also take the time to thank all the developers of this incredible piece of software (PlantUML)! I've been using it quite a bit for about 4 years with no significant problems. I find this level of usability to be very rare for any piece of software, and it is a true testament to the talents and dedication of all those involved!

@arnaudroques
Copy link
Contributor

Well, thanks all!
This is really a collective and collaborative work:

  • some code and patch the core library
  • some improve the CI/CD
  • some write plugins
  • some make suggestions for improvement
  • some report bugs
  • some improve the documentation
  • some translate the documentation
  • some help other on the forum

Each step is important and it's nice to know that this is useful to somebody :-)

@jimnelson372
Copy link
Contributor

jimnelson372 commented May 13, 2024

Hello. I just wrote on a more recent issue, #1680, that I am nearly done with a fix. I'm curious about this case with two groups, one on a self message to the right and one to the left. Here is how the original script would run with my fix. Is this how you would expect two different groups to be? I just want to be sure, since it looks fine to me, but I don't see examples that tell me if groups are expected to align with each other, or if just encapsulating their content, as it would do, is sufficient.

image

@jimnelson372
Copy link
Contributor

Hi @The-Lum ,

I was just looking through open issues to see which may still be related to sequence diagram layouts and I noticed this issue was still open. This grouping of left side self messages was fixed in pull request #1777 and is included in release 1.2024.5, so it can be closed now.

Thanks!

Jim N.

@The-Lum
Copy link
Collaborator

The-Lum commented Jun 4, 2024

Hi all,

[This is an Issue Review] 👀

This is now fixed on V1.2024.5.

Regards.

@The-Lum The-Lum closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants