features/unmarshal_unique: fix codegen for keys/values #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #147
When deciding to intern map keys or values, we were checking if the key or value itself had the extension set. Make it so that we check the map field + tests to confirm behavior.
Additionally, our tests here weren't even verifying the behavior we want!
require.Equal
will dig past the pointers to compare the underlying bytes. We needrequire.Same
. Before this, the test cases pass even ifunique
is disabled.Refs:
testify
: https://github.com/stretchr/testify/blob/v1.9.0/assert/assertions.go#L75bytes.Equal
: https://cs.opensource.google/go/go/+/refs/tags/go1.23.3:src/bytes/bytes.go;l=21Also included
unique.proto
tomake gen-testproto
.Test Plan