Convert binlog.py to go version #41

arindamnayak · 2019-12-12T10:59:08Z

Ported binlog.py to go version.

* pick latest fix from cluster_for_test Signed-off-by: Arindam Nayak <[email protected]>

* tabletmanager lock unlock table test case Signed-off-by: Ajeet jain <[email protected]>

* converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]>

* migrated one of testcase from schema.py to schema_test.go Signed-off-by: Arindam Nayak <[email protected]>

* converted tabletmanager test cases to go Signed-off-by: Ajeet jain <[email protected]>

* ported testcase of keyspace_test.py Signed-off-by: Arindam Nayak <[email protected]>

* Converted sharded test from py to go Signed-off-by: Arindam Nayak <[email protected]>

Signed-off-by: Arindam Nayak <[email protected]>

* pick latest fix from cluster_for_test Signed-off-by: Arindam Nayak <[email protected]>

* tabletmanager lock unlock table test case Signed-off-by: Ajeet jain <[email protected]>

* converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]>

* migrated one of testcase from schema.py to schema_test.go Signed-off-by: Arindam Nayak <[email protected]>

* converted tabletmanager test cases to go Signed-off-by: Ajeet jain <[email protected]>

* ported testcase of keyspace_test.py Signed-off-by: Arindam Nayak <[email protected]>

* Converted sharded test from py to go Signed-off-by: Arindam Nayak <[email protected]>

Signed-off-by: saurabh <[email protected]>

Signed-off-by: Arindam Nayak <[email protected]>

Signed-off-by: saurabh <[email protected]>

Signed-off-by: Arindam Nayak <[email protected]>

Signed-off-by: Ajeet jain <[email protected]> * readme for go endtoend test cases Signed-off-by: Ajeet jain <[email protected]> * Update README.md

Signed-off-by: Arindam Nayak <[email protected]>

deepthi

Can you write a description for each test case similar to how you already have for TestCharset? Maybe also rename TestMain to TestBinlog? or whatever is appropriate.

Also requires a rebase/merge to get unit tests passing.

deepthi · 2019-12-16T21:12:45Z

go/test/endtoend/binlog/binlog_test.go

+//  Insert something that will replicate incorrectly if the charset is not
+//  propagated through binlog streamer to the destination.
+
+//  Vitess tablets default to using utf8, so we insert something crazy and
+//  pretend it's latin1. If the binlog player doesn't also pretend it's
+//  latin1, it will be inserted as utf8, which will change its value.


+1. Nice documentation.

Signed-off-by: Arindam Nayak <[email protected]>

arindamnayak · 2019-12-17T07:48:29Z

Can you write a description for each test case similar to how you already have for TestCharset? Maybe also rename TestMain to TestBinlog? or whatever is appropriate.

Also requires a rebase/merge to get unit tests passing.

Update the documentations. TestMain contains all setup related code, we can't customize that name as it accepts m *testing.M .

It depends on a upstream PR (initial sharding PR), once that is merged and if this PR looks good to you, I will create PR against upstream, where all these unit test case failure will be fixed automatically.

deepthi

LGTM

Signed-off-by: Arindam Nayak <[email protected]>

ajeetj · 2019-12-18T09:59:19Z

LGTM, merging in tal_test_master

Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]>

Signed-off-by: Arindam Nayak <[email protected]>

* Rebase test_master with latest Cluster code (#22) * pick latest fix from cluster_for_test Signed-off-by: Arindam Nayak <[email protected]> * Tabletmanager2 test cases in GO using cluster (#23) * tabletmanager lock unlock table test case Signed-off-by: Ajeet jain <[email protected]> * Vtctld Test cases in Go using cluster (#25) * converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]> * Converted schema.py testcase (#26) * migrated one of testcase from schema.py to schema_test.go Signed-off-by: Arindam Nayak <[email protected]> * Tablet Manager test cases in Go using cluster (#27) * converted tabletmanager test cases to go Signed-off-by: Ajeet jain <[email protected]> * Converted keyspace test to go (#28) * ported testcase of keyspace_test.py Signed-off-by: Arindam Nayak <[email protected]> * Converted sharded test from py to go (#29) * Converted sharded test from py to go Signed-off-by: Arindam Nayak <[email protected]> * initial commit for sharding test Signed-off-by: Arindam Nayak <[email protected]> * added reconciliation assert Signed-off-by: Arindam Nayak <[email protected]> * added insert and stream replication Signed-off-by: Arindam Nayak <[email protected]> * added rest assertions including migrateservedtypes Signed-off-by: Arindam Nayak <[email protected]> * completed remaining assertions and fixed non-workings Signed-off-by: Arindam Nayak <[email protected]> * converted to v3 way of resharding Signed-off-by: Arindam Nayak <[email protected]> * restructured the testcases Signed-off-by: Arindam Nayak <[email protected]> * added testcase with bytes as sharding key type Signed-off-by: Arindam Nayak <[email protected]> * Rebase test_master with latest Cluster code (#22) * pick latest fix from cluster_for_test Signed-off-by: Arindam Nayak <[email protected]> * Tabletmanager2 test cases in GO using cluster (#23) * tabletmanager lock unlock table test case Signed-off-by: Ajeet jain <[email protected]> * Vtctld Test cases in Go using cluster (#25) * converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]> * Converted schema.py testcase (#26) * migrated one of testcase from schema.py to schema_test.go Signed-off-by: Arindam Nayak <[email protected]> * Tablet Manager test cases in Go using cluster (#27) * converted tabletmanager test cases to go Signed-off-by: Ajeet jain <[email protected]> * Converted keyspace test to go (#28) * ported testcase of keyspace_test.py Signed-off-by: Arindam Nayak <[email protected]> * Converted sharded test from py to go (#29) * Converted sharded test from py to go Signed-off-by: Arindam Nayak <[email protected]> * Added testcase for mysqlctl process Signed-off-by: saurabh <[email protected]> * removed unused variables Signed-off-by: saurabh <[email protected]> * removing comment Signed-off-by: saurabh <[email protected]> * addressed review comments Signed-off-by: saurabh <[email protected]> * removed cleandir flag from vttablet teardown Signed-off-by: Arindam Nayak <[email protected]> * added v3 sharding test Signed-off-by: Arindam Nayak <[email protected]> * vtgate buffer testcase migrated in go Signed-off-by: saurabh <[email protected]> * inital code for resharding Signed-off-by: Ajeet jain <[email protected]> * completed the cluster code Signed-off-by: Ajeet jain <[email protected]> * more progress Signed-off-by: Ajeet jain <[email protected]> * pull graceful shutdown code Signed-off-by: Ajeet jain <[email protected]> * added fe more cases in resharding_test.go Signed-off-by: Ajeet jain <[email protected]> * fixed merge issues Signed-off-by: Ajeet jain <[email protected]> * running mysql in parallel mode and fe more assertions Signed-off-by: Ajeet jain <[email protected]> * used rbr mysql mode Signed-off-by: Arindam Nayak <[email protected]> * almost finished with reshading v2 version Signed-off-by: Ajeet jain <[email protected]> * Rebase test_master with latest Cluster code (#22) * pick latest fix from cluster_for_test Signed-off-by: Arindam Nayak <[email protected]> * Tabletmanager2 test cases in GO using cluster (#23) * tabletmanager lock unlock table test case Signed-off-by: Ajeet jain <[email protected]> * Vtctld Test cases in Go using cluster (#25) * converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]> * Converted schema.py testcase (#26) * migrated one of testcase from schema.py to schema_test.go Signed-off-by: Arindam Nayak <[email protected]> * Tablet Manager test cases in Go using cluster (#27) * converted tabletmanager test cases to go Signed-off-by: Ajeet jain <[email protected]> * Converted keyspace test to go (#28) * ported testcase of keyspace_test.py Signed-off-by: Arindam Nayak <[email protected]> * Converted sharded test from py to go (#29) * Converted sharded test from py to go Signed-off-by: Arindam Nayak <[email protected]> * Added testcase for mysqlctl process Signed-off-by: saurabh <[email protected]> * removed unused variables Signed-off-by: saurabh <[email protected]> * removing comment Signed-off-by: saurabh <[email protected]> * addressed review comments Signed-off-by: saurabh <[email protected]> * removed cleandir flag from vttablet teardown Signed-off-by: Arindam Nayak <[email protected]> * vtgate buffer testcase migrated in go Signed-off-by: saurabh <[email protected]> * changed code to use v3 way of sharding Signed-off-by: Arindam Nayak <[email protected]> * converted to v3 way Signed-off-by: Ajeet jain <[email protected]> * added multi split diff and multi sharding Signed-off-by: Arindam Nayak <[email protected]> * converted to v3 way Signed-off-by: Ajeet jain <[email protected]> * TabletManager remaining test cases TabletManager remaining test cases in GO Signed-off-by: Ajeet jain <[email protected]> * moved sql start to non-blocking mode (#35) * moved sql start to non-blocking mode Signed-off-by: Arindam Nayak <[email protected]> * added testcase for vtgate vars Signed-off-by: Arindam Nayak <[email protected]> * implement pr suggestion Signed-off-by: Arindam Nayak <[email protected]> * trying to work with throttler Signed-off-by: Ajeet jain <[email protected]> * use ks1 mysql ports for other tablets in ks2 Signed-off-by: Arindam Nayak <[email protected]> * converted on int keys Signed-off-by: Ajeet jain <[email protected]> * Rebase test_master with latest Cluster code (#22) * pick latest fix from cluster_for_test Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * Tabletmanager2 test cases in GO using cluster (#23) * tabletmanager lock unlock table test case Signed-off-by: Ajeet jain <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * Vtctld Test cases in Go using cluster (#25) * converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * Converted schema.py testcase (#26) * migrated one of testcase from schema.py to schema_test.go Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * Tablet Manager test cases in Go using cluster (#27) * converted tabletmanager test cases to go Signed-off-by: Ajeet jain <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * Converted keyspace test to go (#28) * ported testcase of keyspace_test.py Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * Converted sharded test from py to go (#29) * Converted sharded test from py to go Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * Added testcase for mysqlctl process Signed-off-by: saurabh <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * removed unused variables Signed-off-by: saurabh <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * removing comment Signed-off-by: saurabh <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * addressed review comments Signed-off-by: saurabh <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * removed cleandir flag from vttablet teardown Signed-off-by: Arindam Nayak <[email protected]> * vtgate buffer testcase migrated in go Signed-off-by: saurabh <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * TabletManager remaining test cases TabletManager remaining test cases in GO Signed-off-by: Ajeet jain <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * moved sql start to non-blocking mode (#35) * moved sql start to non-blocking mode Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * added testcase for vtgate vars Signed-off-by: Arindam Nayak <[email protected]> * redirect process errors to log files (#38) Signed-off-by: Arindam Nayak <[email protected]> * debug the test error in ci Signed-off-by: Arindam Nayak <[email protected]> * fix initial sharding multi Signed-off-by: Arindam Nayak <[email protected]> * fixed protected mysqlctl teardown Signed-off-by: Arindam Nayak <[email protected]> * removed sleep time Signed-off-by: Ajeet jain <[email protected]> * refactor mysqlctl start and stop Signed-off-by: Arindam Nayak <[email protected]> * Fixed multisplitdiff command Signed-off-by: Arindam Nayak <[email protected]> * added log statement for error condition Signed-off-by: Arindam Nayak <[email protected]> * Ignoring Python tests which are moved to GO (#40) Signed-off-by: Ajeet jain <[email protected]> * readme for go endtoend test cases Signed-off-by: Ajeet jain <[email protected]> * Update README.md * Fixed byte column test cases Signed-off-by: Ajeet jain <[email protected]> * lint fixes Signed-off-by: Ajeet jain <[email protected]> * updated comments Signed-off-by: Arindam Nayak <[email protected]> * restructure of launch cluster Signed-off-by: Ajeet jain <[email protected]> * fix tear down code Signed-off-by: Ajeet jain <[email protected]> * Refactor code Signed-off-by: Arindam Nayak <[email protected]> * fix the throttler test cases Signed-off-by: Ajeet jain <[email protected]> * fix the static checks Signed-off-by: Ajeet jain <[email protected]> * disable running python test cases in travis Signed-off-by: Ajeet jain <[email protected]> * fixed static checks Signed-off-by: Ajeet jain <[email protected]> * removed unrequired line to set RBR mode Signed-off-by: Ajeet jain <[email protected]> * Add matrix build for mysql Signed-off-by: Morgan Tocker <[email protected]> * Add additional flavors, move flaky test Signed-off-by: Morgan Tocker <[email protected]> * vindex: add required NeedVCursor function There's currently no way to know if a vindex requires the vcursor. We need this knowledge to prevent vreplication from choosing a vindex that requires a VCursor. This change requires all vindexes to report if they need the vcursor or not. Signed-off-by: Sugu Sougoumarane <[email protected]> * vrepl: choose best vindex instead of primary Signed-off-by: Sugu Sougoumarane <[email protected]> * few of the reparent test cases Signed-off-by: Ajeet jain <[email protected]> * vttablet-up.sh : Adds detection of mysqld launch failure. Given failure, tests for further for presence of apparmor. Exits with error and recommendation to disable. Signed-off-by: ChrisR <[email protected]> * completed all the reparent tests Signed-off-by: Ajeet jain <[email protected]> * Remove MariaDB 10.1 Re-enable unit race Change CI git checkout to be v2.0 Disable test caching Signed-off-by: Morgan Tocker <[email protected]> * Revert some of the MariaDB changes, fix unit_race Signed-off-by: Morgan Tocker <[email protected]> * Add debugging for macOS issue Signed-off-by: Morgan Tocker <[email protected]> * Add additional flaky test Signed-off-by: Morgan Tocker <[email protected]> * Add sleep for macOS Signed-off-by: Morgan Tocker <[email protected]> * Disable macOS local example for now (flaky) Signed-off-by: Morgan Tocker <[email protected]> * Disable unit_race again Signed-off-by: Morgan Tocker <[email protected]> * updated test cases for reparent Signed-off-by: Ajeet jain <[email protected]> * Resharding endtoend testcases in Go migrated from Python (#44) Signed-off-by: Ajeet jain <[email protected]> * fix vtgate schema testcases Signed-off-by: Ajeet jain <[email protected]> * Convert binlog.py to go version (#41) Signed-off-by: Arindam Nayak <[email protected]> * fixed range based reparenting Signed-off-by: Ajeet jain <[email protected]> * removed unrequired comments Signed-off-by: Ajeet jain <[email protected]> * Modified apparmor detection to passive, added additional investigation info. Signed-off-by: ChrisR <[email protected]> * make-release-packages.sh: Disable shellcheck 1091 and Add README pointing to local install instructions Signed-off-by: Gary Edgar <[email protected]> * review comments addressed Signed-off-by: Ajeet jain <[email protected]> * Splitting github endtoend action into 2 files Signed-off-by: Ajeet jain <[email protected]> * vindex: NeedVCursor->NeedsVCursor Signed-off-by: Sugu Sougoumarane <[email protected]> * Set correct tablet type to fix failing test Signed-off-by: Arindam Nayak <[email protected]> * Fixing initial sharding multi Signed-off-by: Arindam Nayak <[email protected]> * fix the assertions Signed-off-by: Arindam Nayak <[email protected]> * fixed master-spare test case Signed-off-by: Ajeet jain <[email protected]> * Testing dockerized test in github workflow Signed-off-by: Arindam Nayak <[email protected]> * Vertical split testcase migrated in go (#46) Vertical split endtoend testcases in Go migrated from Python Signed-off-by: saurabh <[email protected]> * Adjusted shard number for testcase Signed-off-by: Arindam Nayak <[email protected]> * Reverting changes for config.json Signed-off-by: Arindam Nayak <[email protected]> * Refactor vitess/lite Dockerfiles. (vitessio#5592) Signed-off-by: Anthony Yeh <[email protected]> Co-authored-by: Arindam Nayak <[email protected]> Co-authored-by: saurabh408 <[email protected]> Co-authored-by: Morgan Tocker <[email protected]> Co-authored-by: Sugu Sougoumarane <[email protected]> Co-authored-by: ChrisR <[email protected]> Co-authored-by: Gary Edgar <[email protected]> Co-authored-by: Anthony Yeh <[email protected]> Co-authored-by: Deepthi Sigireddi <[email protected]>

arindamnayak and others added 30 commits October 31, 2019 12:17

Rebase test_master with latest Cluster code (#22)

d538d86

* pick latest fix from cluster_for_test Signed-off-by: Arindam Nayak <[email protected]>

Tabletmanager2 test cases in GO using cluster (#23)

f638869

* tabletmanager lock unlock table test case Signed-off-by: Ajeet jain <[email protected]>

Vtctld Test cases in Go using cluster (#25)

ae542e3

* converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]>

Converted schema.py testcase (#26)

c8dac4a

* migrated one of testcase from schema.py to schema_test.go Signed-off-by: Arindam Nayak <[email protected]>

Tablet Manager test cases in Go using cluster (#27)

3dc75a9

* converted tabletmanager test cases to go Signed-off-by: Ajeet jain <[email protected]>

Converted keyspace test to go (#28)

c99d4e1

* ported testcase of keyspace_test.py Signed-off-by: Arindam Nayak <[email protected]>

Converted sharded test from py to go (#29)

98a5e40

* Converted sharded test from py to go Signed-off-by: Arindam Nayak <[email protected]>

initial commit for sharding test

aa3b68b

Signed-off-by: Arindam Nayak <[email protected]>

added reconciliation assert

0f90bf9

Signed-off-by: Arindam Nayak <[email protected]>

added insert and stream replication

ed5a789

Signed-off-by: Arindam Nayak <[email protected]>

added rest assertions including migrateservedtypes

8cec35b

Signed-off-by: Arindam Nayak <[email protected]>

completed remaining assertions and fixed non-workings

c73595f

Signed-off-by: Arindam Nayak <[email protected]>

converted to v3 way of resharding

a48bb48

Signed-off-by: Arindam Nayak <[email protected]>

restructured the testcases

586ba3b

Signed-off-by: Arindam Nayak <[email protected]>

added testcase with bytes as sharding key type

52e88d9

Signed-off-by: Arindam Nayak <[email protected]>

added v3 sharding test

4fb8a33

Signed-off-by: Arindam Nayak <[email protected]>

used rbr mysql mode

8e83cd5

Signed-off-by: Arindam Nayak <[email protected]>

Rebase test_master with latest Cluster code (#22)

fc1a866

* pick latest fix from cluster_for_test Signed-off-by: Arindam Nayak <[email protected]>

Tabletmanager2 test cases in GO using cluster (#23)

62be70d

* tabletmanager lock unlock table test case Signed-off-by: Ajeet jain <[email protected]>

Vtctld Test cases in Go using cluster (#25)

11e9809

* converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]>

Converted schema.py testcase (#26)

20d7016

* migrated one of testcase from schema.py to schema_test.go Signed-off-by: Arindam Nayak <[email protected]>

Tablet Manager test cases in Go using cluster (#27)

291566d

* converted tabletmanager test cases to go Signed-off-by: Ajeet jain <[email protected]>

Converted keyspace test to go (#28)

23a0872

* ported testcase of keyspace_test.py Signed-off-by: Arindam Nayak <[email protected]>

Converted sharded test from py to go (#29)

5f08311

* Converted sharded test from py to go Signed-off-by: Arindam Nayak <[email protected]>

Added testcase for mysqlctl process

55d1cd5

Signed-off-by: saurabh <[email protected]>

removed unused variables

0681679

Signed-off-by: saurabh <[email protected]>

removing comment

333f424

Signed-off-by: saurabh <[email protected]>

addressed review comments

dfd992e

Signed-off-by: saurabh <[email protected]>

removed cleandir flag from vttablet teardown

848c29c

Signed-off-by: Arindam Nayak <[email protected]>

vtgate buffer testcase migrated in go

4277b59

Signed-off-by: saurabh <[email protected]>

arindamnayak and others added 13 commits December 6, 2019 18:34

fix initial sharding multi

91212cb

Signed-off-by: Arindam Nayak <[email protected]>

Merge branch 'tal_test_master' into tal_test_initial_sharding_v3

5a88206

fixed protected mysqlctl teardown

99f1b28

Signed-off-by: Arindam Nayak <[email protected]>

refactor mysqlctl start and stop

19a5225

Signed-off-by: Arindam Nayak <[email protected]>

Fixed multisplitdiff command

fa5edf5

Signed-off-by: Arindam Nayak <[email protected]>

added log statement for error condition

db7c8d2

Signed-off-by: Arindam Nayak <[email protected]>

Ignoring Python tests which are moved to GO (#40)

76293e5

Signed-off-by: Ajeet jain <[email protected]> * readme for go endtoend test cases Signed-off-by: Ajeet jain <[email protected]> * Update README.md

Merge branch 'tal_test_master' into tal_test_initial_sharding_v3

b14ecc4

updated comments

ae8e4c0

Signed-off-by: Arindam Nayak <[email protected]>

Refactor code

c2633e4

Signed-off-by: Arindam Nayak <[email protected]>

added setup code for binlog.py

61100c7

Signed-off-by: Arindam Nayak <[email protected]>

added charset test to binlog

cd73303

Signed-off-by: Arindam Nayak <[email protected]>

completed binlog tests

ea327eb

Signed-off-by: Arindam Nayak <[email protected]>

arindamnayak requested a review from sougou as a code owner December 12, 2019 10:59

arindamnayak force-pushed the tal_binlog_test branch from fb148ad to 6cbd5a3 Compare December 12, 2019 11:18

deepthi reviewed Dec 16, 2019

View reviewed changes

added query check for binlog streams

572c112

Signed-off-by: Arindam Nayak <[email protected]>

arindamnayak force-pushed the tal_binlog_test branch from 6cbd5a3 to 572c112 Compare December 17, 2019 07:41

deepthi approved these changes Dec 18, 2019

View reviewed changes

arindamnayak changed the base branch from tal_test_initial_sharding_v3 to tal_test_master December 18, 2019 06:07

arindamnayak and others added 2 commits December 18, 2019 13:25

Merge branch 'tal_test_master' into tal_binlog_test

3e75d63

Fix after merge conflict

61312bf

Signed-off-by: Arindam Nayak <[email protected]>

arindamnayak force-pushed the tal_binlog_test branch from 9cc4561 to 61312bf Compare December 18, 2019 09:21

ajeetj merged commit 76d6f62 into tal_test_master Dec 18, 2019

arindamnayak added a commit that referenced this pull request Dec 18, 2019

Convert binlog.py to go version (#41)

33c4569

Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]>

ajeetj pushed a commit that referenced this pull request Dec 19, 2019

Convert binlog.py to go version (#41)

6278cdd

Signed-off-by: Arindam Nayak <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert binlog.py to go version #41

Convert binlog.py to go version #41

arindamnayak commented Dec 12, 2019

deepthi left a comment •

edited

Loading

deepthi Dec 16, 2019

arindamnayak commented Dec 17, 2019

deepthi left a comment

ajeetj commented Dec 18, 2019

Convert binlog.py to go version #41

Convert binlog.py to go version #41

Conversation

arindamnayak commented Dec 12, 2019

deepthi left a comment • edited Loading

Choose a reason for hiding this comment

deepthi Dec 16, 2019

Choose a reason for hiding this comment

arindamnayak commented Dec 17, 2019

deepthi left a comment

Choose a reason for hiding this comment

ajeetj commented Dec 18, 2019

deepthi left a comment •

edited

Loading