Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following improvements have been made:
Updated the Go version from 1.13 to 1.15. This is done for two reasons. First, we should always aim to use the latest version, this is a common theme in Go projects, and each version provides more performance or overall UX improvements we need. Second, starting with Go 1.14, the
go
command line CLI now automatically detects thevendor/
folder and uses that duringgo build
andgo test
. This is needed, so the CI detects any inconsistencies during a pull request and that the source code is 100% buildable.I removed the
Get dependencies
part because we're vendoring the source code, andgo get
makes a network call to fetch dependencies. We don't need to fetch the dependencies again because our "source of truth" is thevendor/
folder. This particular step also breaks our CI if we start using private dependencies (i.e., Extract psapi into github.com/planetscale/planetscale-go #27). We could configure our CI to makego get
work easily, but I think we don't need it for now due to the usage of thevendor/
folder. (nit: we might need a private key in the future to verify the vendor folder + go.mod changes, but the ability to verify it is not yet implemented by the Go team cmd/go: allow verifying vendored code golang/go#27348)I removed the
-v
flag fromgo test -v
. The main reason is that-v
outputs too much information. It's not needed. The best outcome is to output only the issues we see. The benefit is, it's easier to parse the CI output for humans, and we don't have to scroll hundreds of lines.Before:
After: