Staking page update #679
Merged
Staking page update #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sirmorrison
force-pushed
the
staking_page
branch
from
b24e907
to
a00ddf7
Compare
dreacot
requested changes
Nov 4, 2021
There was a problem hiding this comment.
- Touching the backdrop should close the modal
- the got it text on the info dialogs should be by the right
- going to the all tickets page, switching wallets using the dropdown filter and then clicking on a ticket opens the ticket details page, but clicking the back arrow resets the filter to the default wallet on the dropdown, it should remain as the wallet you selected
- Ideally the only thing that should have changed to stake was the button label on the modal to stake tickets, and the reason for that was because the users were not really purchasing tickets, and it was agreed to used the word stake there
This is not related to this PR. Hence will be resolved from another PR. |
dreacot
requested changes
Nov 8, 2021
This was removed during the initial page clean up as it was seen as being redundant by @C-ollins. As it is a direct replica of the view all ticket page. |
- set stake button min width - rename all instance of tickets to staking on overview page - add No live stake label to live stake section - hide see all btn when no live stake - set see all btn size to mockup design - add see all btn to stake record section - hde see all btn when not stake record
- update staking modal to ui - add ticket increment and decrement funtionality. - comment out ticket review modal
- use clickableList for vsp selector modal - minimize vsp modal on background click. - fix wallet total account balance - automatically set last selected vsp host on resume - clean up code
- Add content alignment to info modal - Add loader icon to ticket purchase modal - Hide cancel button when loader icon is displayed. - Remove password editor error when there is a change event. - remove purchase overview modal file
- update list view to mockup ui - clean up code
- group overview, transaction, wallet(subpages also) into package
- Minimise purchase modal when backdrop is clicked. - Fix info modal button alignment.
Sirmorrison
force-pushed
the
staking_page
branch
from
a31301f
to
28abc03
Compare
okay |
dreacot
approved these changes
Nov 8, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* rename tickets package to staking * rename ticket icons - set stake button min width - rename all instance of tickets to staking on overview page - add No live stake label to live stake section - hide see all btn when no live stake - set see all btn size to mockup design - add see all btn to stake record section - hde see all btn when not stake record * implement spend from unmixed account * Clean up modal layout - update staking modal to ui - add ticket increment and decrement funtionality. - comment out ticket review modal * fix vsp selector bug when new vsp is selected - use clickableList for vsp selector modal - minimize vsp modal on background click. - fix wallet total account balance - automatically set last selected vsp host on resume - clean up code * Add success notification modal - Add content alignment to info modal - Add loader icon to ticket purchase modal - Hide cancel button when loader icon is displayed. - Remove password editor error when there is a change event. - remove purchase overview modal file * use ticket list view on ticket overview page * Add tooltips to ticket list view - update list view to mockup ui - clean up code * Add staking redirect to tx details page functionality - group overview, transaction, wallet(subpages also) into package * fix lint * remove commented code * revert rename changes - Minimise purchase modal when backdrop is clicked. - Fix info modal button alignment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #660
fix #674
Fix #648
*** Further clean up of the overview, wallet, transaction packages will commence in subsequent PRs.