-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Editors when tab key is pressed #640
Conversation
the behavior of the tab key isn't consistent across all modals, i.e on some modals pressing the tab key repeatedly recycles back to the first input box, while on some others it ends on the last input box. The recycling to the first input box behavior should be consistent across all modals these are modals where i noticed the non recycling behavior |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that on pages where no editor is focused on resume, if the tab button is pressed a couple of times, and then an editor is selected, the behavior below is observed.
This can be seen on the verify message page, modals with multiple editors, seed restore page etc.
To resolved this, you may need to set focus to an editor on page resume.
* Switch editors on Verify message page when tab key is pressed * Move Tab key event handler to utils * Add tab key event to Sign Message page * Switch editors on password modal when tab is pressed * Switch editors when tab is pressed on Restore wallet page * Make tab event handler cyclic * Fix create restore editors not being recyclable * Switch editors on watch only modal when tab is pressed * Switch seed editors when tab key is pressed * Switch editors on send page when tab is pressed * Add condition for create password modal without name * Move tab key event functions to decredmaterial * Revert VerifyMessage arguments * Focus on first editor on page resume * Focus on first editor on Create Restor Page * implement tab key for usd amount editor when currency is set to usd
Closed #589
This PR enables ediotrs to be switched when the tab key is pressed on the following pages and modals: