Group pages and modals into packages #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshorefueled
force-pushed
the
group_modals
branch
3 times, most recently
from
f7cf6b6
to
96e215d
Compare
oshorefueled
force-pushed
the
group_modals
branch
from
c07749b
to
487d34c
Compare
beansgum
suggested changes
Jul 7, 2021
oshorefueled
force-pushed
the
group_modals
branch
from
c22da7a
to
689bed2
Compare
beansgum
suggested changes
Jul 8, 2021
beansgum
suggested changes
Jul 8, 2021
oshorefueled
force-pushed
the
group_modals
branch
from
52a2416
to
8e44d87
Compare
beansgum
suggested changes
Jul 9, 2021
* create modal and page packages and move modals and pages into them respectively. * add a load package. Load replaces the common type and holds data that is shared among ui components in the ui package.
oshorefueled
force-pushed
the
group_modals
branch
from
8e44d87
to
bb98f32
Compare
- add comments to the load package and utils file - move help page to page package - move sign message page to page package - move receive page to page package - move security tools, validate and verify message pages - move settings page to page package - move the more page to page package - move overview and transaction pages to page package
- add transactions page to case for sending wallet notifications - go fmt load.go
- move seed backup page to the page package
- replace parameters in window methods from interface type to Modal and Page types
- append PageID as a Suffix to page constants - restore html code which were removed from modal template file during rebase - remove unused structs
- rebase on master branch - change wallet page ID constant to WalletPageID
oshorefueled
force-pushed
the
group_modals
branch
from
bb98f32
to
26f1b11
Compare
dreacot
approved these changes
Jul 13, 2021
beansgum
approved these changes
Jul 13, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* move create password modal to modal package * move modals to modal package * add load package * create modal and page packages and move modals and pages into them respectively. * add a load package. Load replaces the common type and holds data that is shared among ui components in the ui package. * cleanup errors on main page * move pages from ui to page package - add comments to the load package and utils file - move help page to page package - move sign message page to page package - move receive page to page package - move security tools, validate and verify message pages - move settings page to page package - move the more page to page package - move overview and transaction pages to page package * fix wrong call on theme in statistics page - add transactions page to case for sending wallet notifications - go fmt load.go * resolve crash when internet connection is off * resolve go lint issues * move account details, restore wallet, wallet page to page package - move seed backup page to the page package * add interface file to the load package - replace parameters in window methods from interface type to Modal and Page types * delete unused modals in the ui package * move license page to the page package * uncomment code related to pages that have been moved - append PageID as a Suffix to page constants - restore html code which were removed from modal template file during rebase - remove unused structs * re-arrange package imports - rebase on master branch - change wallet page ID constant to WalletPageID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs groups pages and modals into their own packages. It also adds a load package which would replace the common struct shared among pages, modals and a number of other godcr components.