Transaction, overview UI & code cleanup #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshorefueled
force-pushed
the
transaction_dims
branch
3 times, most recently
from
b02f002
to
9cd4fca
Compare
|
JustinBeBoy
suggested changes
Mar 30, 2021
| }), | ||
| layout.Stacked(func(gtx layout.Context) layout.Dimensions { | ||
| fillWidth := progressBarWidth * clamp1(p.Progress) | ||
| fillColor := p.Color |
There was a problem hiding this comment.
The progress color is "41BE53" and background is E6EAED
There was a problem hiding this comment.
Yes, the colours for the track and progress are set on the pages using the progress bar widget
|
The margin is 24 |
- Correct inaccurate colours and dimension on the top bar. The colour used as background and separator colour was wrong. Receive and Send icons are also replaced with the samesize as those on the mockups. - Add a container wrapper to differentiate when an inset is used as a margin or padding
- Add a filtering method to filter transaction by direction. It replaces previous transactions filtering where transaction rows were being hidden. - Correct dimensions and alignment of the transaction row
- add separator widget and replace repetitive line implementation on pages - move code that will be removed when all pages have been updated to the mockup designs to a deprecated file. - move general page components such as the side nav and top bar to a component.go file.
- modify progress bar, adding an exported Height field. The default progress bar sets the max height to 4DP which doesn't allow a 8DP height as specified in the overview mockup. - make appropriate dimesion and text size corrections to the overview page. - clean up code by adding code that aren't layout code to the util.go file.
- add comments to compontents, util and deprecated.go files - remove top padding on transactions list
- change color name from IconColor to Gray3
- add inactive colour to side nav text
I'm not sure how to reproduce that error, you can create that as an issue and it will be resolved on another PR. |
oshorefueled
force-pushed
the
transaction_dims
branch
from
f0bc6ef
to
36cbb89
Compare
dreacot
approved these changes
Apr 7, 2021
dreacot
approved these changes
Apr 7, 2021
beansgum
approved these changes
Apr 7, 2021
JustinBeBoy
approved these changes
Apr 7, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* add comma to wallet balance * make colour and dimension corrections - Add a container wrapper to differentiate when an inset is used as a margin or padding * correct dimensions and layout of transaction list - Add a filtering method to filter transaction by direction. It replaces previous transactions filtering where transaction rows were being hidden. - Correct dimensions and alignment of the transaction row * multi: add separator widget - add separator widget and replace repetitive line implementation on pages - move code that will be removed when all pages have been updated to the mockup designs to a deprecated file. - move general page components such as the side nav and top bar to a component.go file. * multi: correct ui dimension on overview page - modify progress bar, adding an exported Height field. The default progress bar sets the max height to 4DP which doesn't allow a 8DP height as specified in the overview mockup. - clean up code by adding code that aren't layout code to the util.go file. * multi: make deep blue the default text colour - add inactive colour to side nav text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #344.
It also:
comments were added to each file describing the code that they contain.
height as specified in the overview mockup.
setting the width of the line. The same code is also present in PR make entire wallet option row clickable #330.
padding or margin. Its purpose is to help visualize the structure of a layout from the code.