Wallet settings page #298
Merged
Wallet settings page #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sirmorrison
force-pushed
the
settings_page
branch
4 times, most recently
from
f15e6e2
to
d3173e0
Compare
oshorefueled
suggested changes
Jan 13, 2021
|
Old spending password doesn't get cleared when I use the cancel button or when I successfully change my wallet password
|
|
Kindly change the label on the remove wallet modal to "Spending password" |
resolved |
Sirmorrison
force-pushed
the
settings_page
branch
from
2db4e17
to
718173f
Compare
|
Kindly make the change in the mockup to the settings page.
|
Sirmorrison
force-pushed
the
settings_page
branch
2 times, most recently
from
54b597e
to
622e9be
Compare
oshorefueled
previously approved these changes
Jan 19, 2021
Sirmorrison
force-pushed
the
settings_page
branch
3 times, most recently
from
0b16270
to
5495c18
Compare
* implement change wallet password funtionality * add tx notification section
* add debug and deletwallet sections
* add password strength bar to modal template * clean up wallet settings code
* implement wallet rescan functionality * clean up setings page code * undo changes to notifyOnSuccess() * fix typo on modal template
* clean up code * use rescanBlock() instead of restartSync() * reset old password input field
Sirmorrison
force-pushed
the
settings_page
branch
from
5495c18
to
2588380
Compare
oshorefueled
approved these changes
Jan 22, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* add switch widget * add transaction notification section * add layout without info icon * add debug and delete wallet sections * restore change wallet password functionality * add password strength bar to modal template * restore delete wallet functionality * implement wallet rescan functionality * implement update to subpage header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #287
This Pr implement godcr settings page