-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add v2 wallet settings page #1036
Conversation
Regarding the description, I think closes is a better verb because the issue is not a bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
When disabling fetching of proposals, proposals notifications should also default to being turned off
-
clicking on "Check wallet log" crashes the app. see log below;
2022/08/16 19:49:05 FATAL -- failed to create Watcher
goroutine 322 [running]:
runtime/debug.Stack()
/usr/local/go/src/runtime/debug/stack.go:24 +0x65
github.com/nxadm/tail/util.Fatal({0x17e8c8b, 0xc8b90b}, {0x0, 0x0, 0x0})
/home/kennedy/Projects/pkg/mod/github.com/nxadm/[email protected]/util/util.go:22 +0x97
github.com/nxadm/tail/watch.(*InotifyTracker).run(0xc006e10600)
/home/kennedy/Projects/pkg/mod/github.com/nxadm/[email protected]/watch/inotify_tracker.go:219 +0x68
created by github.com/nxadm/tail/watch.glob..func1
/home/kennedy/Projects/pkg/mod/github.com/nxadm/[email protected]/watch/inotify_tracker.go:54 +0x173
exit status 1
i don't really think it matters... the idea is to link the pr to the issue and it does just that.. |
@dreacot i could not reproduce this. what where your repro steps? also the log does not point to any godcr file. 2022/08/16 19:49:05 FATAL -- failed to create Watcher |
I cannot reproduce the error too |
- add ok string local and replace Got it strings on settings page. - fix bug with proposal notification being active when proposal fetching is disabled - minor code cleanup
0af292c
to
4201cd6
Compare
|
- Set fixed modal width. - Fix lint error from PR rebase. - Update verify message info modal message to mockup - Update subpage info modal button color and position.
- Update create wallet account modal to updated mockup design - Minor code clean up
This Pr Fix #1033
This Pr implement the V2 dcr wallet settings design and all its functionalities.