Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add v2 wallet settings page #1036

Merged
merged 11 commits into from
Aug 24, 2022
Merged

Conversation

Sirmorrison
Copy link
Contributor

@Sirmorrison Sirmorrison commented Aug 9, 2022

This Pr Fix #1033
This Pr implement the V2 dcr wallet settings design and all its functionalities.

image

@Sirmorrison Sirmorrison marked this pull request as ready for review August 16, 2022 10:33
@devchoplife
Copy link
Contributor

Regarding the description, I think closes is a better verb because the issue is not a bug.

Copy link
Contributor

@devchoplife devchoplife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The page content width should be reduced as seen on the mockup:
    image

vs
image

ui/page/security/validate_address.go Outdated Show resolved Hide resolved
ui/values/localizable/es.go Show resolved Hide resolved
ui/values/localizable/es.go Show resolved Hide resolved
ui/values/localizable/es.go Show resolved Hide resolved
ui/values/localizable/fr.go Show resolved Hide resolved
ui/values/localizable/fr.go Show resolved Hide resolved
ui/values/localizable/fr.go Show resolved Hide resolved
Copy link
Collaborator

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When disabling fetching of proposals, proposals notifications should also default to being turned off
    Screenshot from 2022-08-16 19-47-58

  2. clicking on "Check wallet log" crashes the app. see log below;

2022/08/16 19:49:05 FATAL -- failed to create Watcher
goroutine 322 [running]:
runtime/debug.Stack()
        /usr/local/go/src/runtime/debug/stack.go:24 +0x65
github.com/nxadm/tail/util.Fatal({0x17e8c8b, 0xc8b90b}, {0x0, 0x0, 0x0})
        /home/kennedy/Projects/pkg/mod/github.com/nxadm/[email protected]/util/util.go:22 +0x97
github.com/nxadm/tail/watch.(*InotifyTracker).run(0xc006e10600)
        /home/kennedy/Projects/pkg/mod/github.com/nxadm/[email protected]/watch/inotify_tracker.go:219 +0x68
created by github.com/nxadm/tail/watch.glob..func1
        /home/kennedy/Projects/pkg/mod/github.com/nxadm/[email protected]/watch/inotify_tracker.go:54 +0x173
exit status 1
  1. The modal below should say "OK" based on the mockup, it also looks like there is excessive top and bottom spacing. on second thought, due to the vast amount of modals that requiring changing, this would be better suited in it's own PR
    Screenshot from 2022-08-16 19-52-39
    Screenshot from 2022-08-16 19-53-47

@Sirmorrison
Copy link
Contributor Author

Regarding the description, I think closes is a better verb because the issue is not a bug.

i don't really think it matters... the idea is to link the pr to the issue and it does just that..

@Sirmorrison
Copy link
Contributor Author

Sirmorrison commented Aug 18, 2022

  • The page content width should be reduced as seen on the mockup:
    image

vs image

the mockup shows the design in full screen... kindly open the app in full display and compare. I would however add the indentation on the left.

@Sirmorrison
Copy link
Contributor Author

@dreacot i could not reproduce this. what where your repro steps? also the log does not point to any godcr file.

2022/08/16 19:49:05 FATAL -- failed to create Watcher
goroutine 322 [running]:
runtime/debug.Stack()
/usr/local/go/src/runtime/debug/stack.go:24 +0x65
github.com/nxadm/tail/util.Fatal({0x17e8c8b, 0xc8b90b}, {0x0, 0x0, 0x0})
/home/kennedy/Projects/pkg/mod/github.com/nxadm/[email protected]/util/util.go:22 +0x97
github.com/nxadm/tail/watch.(*InotifyTracker).run(0xc006e10600)
/home/kennedy/Projects/pkg/mod/github.com/nxadm/[email protected]/watch/inotify_tracker.go:219 +0x68
created by github.com/nxadm/tail/watch.glob..func1
/home/kennedy/Projects/pkg/mod/github.com/nxadm/[email protected]/watch/inotify_tracker.go:54 +0x173
exit status 1

@devchoplife
Copy link
Contributor

@dreacot i could not reproduce this. what where your repro steps? also the log does not point to any godcr file.

2022/08/16 19:49:05 FATAL -- failed to create Watcher goroutine 322 [running]: runtime/debug.Stack() /usr/local/go/src/runtime/debug/stack.go:24 +0x65 github.com/nxadm/tail/util.Fatal({0x17e8c8b, 0xc8b90b}, {0x0, 0x0, 0x0}) /home/kennedy/Projects/pkg/mod/github.com/nxadm/[email protected]/util/util.go:22 +0x97 github.com/nxadm/tail/watch.(*InotifyTracker).run(0xc006e10600) /home/kennedy/Projects/pkg/mod/github.com/nxadm/[email protected]/watch/inotify_tracker.go:219 +0x68 created by github.com/nxadm/tail/watch.glob..func1 /home/kennedy/Projects/pkg/mod/github.com/nxadm/[email protected]/watch/inotify_tracker.go:54 +0x173 exit status 1

I cannot reproduce the error too

@JustinBeBoy
Copy link
Contributor

  1. add notice when sign message success like mockup and remove background of "signature" text

image

  1. "DCR" not "DC"

aaaaaa

  1. Seem like modal to create new account of wallet ui not like mockup
    app:

bb1

vs mockup:

bb2

  1. modal info of verify message and sign message not like mockup

cccc

vs

cccc2

ui/modal/text_input_modal.go Outdated Show resolved Hide resolved
@Sirmorrison
Copy link
Contributor Author

  • add notice when sign message success like mockup and remove background of "signature" text
    image
    There is a Pr Convert all Toast alerts to Modals #1039 already to resolve this no need implementing this twice.

- Set fixed modal width.
- Fix lint error from PR rebase.
- Update verify message info modal message to mockup
- Update subpage info modal button color and position.
- Update create wallet account modal to updated mockup design
- Minor code clean up
ui/page/wallet_settings_page.go Outdated Show resolved Hide resolved
ui/page/wallet_settings_page.go Show resolved Hide resolved
ui/page/wallet_settings_page.go Show resolved Hide resolved
@JustinBeBoy
Copy link
Contributor

1 nothing show when change account name successful
1111

  1. please remove back button

2222

@Sirmorrison Sirmorrison dismissed dreacot’s stale review August 24, 2022 11:11

change implemented

@Sirmorrison Sirmorrison merged commit 703460f into planetdecred:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Decred specific settings
4 participants