Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stakeshuffle page UI #1024

Closed
wants to merge 26 commits into from
Closed

Update stakeshuffle page UI #1024

wants to merge 26 commits into from

Conversation

devchoplife
Copy link
Contributor

@devchoplife devchoplife commented Jul 27, 2022

Closes #1019
Fixes #1040
This PR updates the mixer page to the latest UI

image

@devchoplife devchoplife marked this pull request as ready for review July 30, 2022 20:38
Copy link
Contributor

@JustinBeBoy JustinBeBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't start mixing
image

ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
@devchoplife
Copy link
Contributor Author

I can't start mixing image

This PR focuses on the UI
The functionality of the mixer is excluded

@JustinBeBoy
Copy link
Contributor

JustinBeBoy commented Jul 31, 2022

I can't start mixing image

This PR focuses on the UI The functionality of the mixer is excluded

I can't start mixing at the moment so that hinders the review of this PR, I can't see the way of the progress works

@devchoplife
Copy link
Contributor Author

I can't start mixing image

This PR focuses on the UI The functionality of the mixer is excluded

I can't start mixing at the moment so that hinders the review of this PR, I can't see the way of the progress works

The progress bar functionality has not been implemented, this PR only updates the UI to V2

Copy link
Contributor

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The icon seems blurry and not centralized

ui/page/components/acct_mixer.go Outdated Show resolved Hide resolved
ui/page/components/acct_mixer.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
@devchoplife
Copy link
Contributor Author

image

The icon seems blurry and not centralized

I extracted from figma
I will check if I can get a clearer one

ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
ui/page/privacy/account_mixer_page.go Outdated Show resolved Hide resolved
@JustinBeBoy
Copy link
Contributor

@devchoplife I see many comments @Sirmorrison that you marked solved, I checked again but it is not resolved, please check it again

@dreacot
Copy link
Collaborator

dreacot commented Aug 3, 2022

I can't start mixing image

This PR focuses on the UI The functionality of the mixer is excluded

Why does this PR just focus on UI, the more UI we implement without functionality, the farther it takes us away from out goal.
Excepts there's a block in implementing the functionality, let's resolve it at the same time.

Because there isn't even a proper way to ensure the UI implementation is correct if the functionality doesn't work

Copy link
Collaborator

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the layout can still be improved;

  1. The trailing "DCR" of the balance should be bolder and larger
  2. the mixed and unmixed balances should have a trailing DCR, the decimals can go for zero balances as well
  3. the "Mixer" text should be a lighter shade of gray
  4. looks like the max width of the mixer card should be reduced

Screenshot from 2022-08-03 11-17-43

Screenshot from 2022-08-03 11-17-56

@devchoplife devchoplife marked this pull request as draft August 6, 2022 08:22
@devchoplife devchoplife closed this by deleting the head repository Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crash when stakeshufle page is navigated to v2 stake shuffle layout update.
4 participants