Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate General section functionality to the app level settings page. #1012

Closed
wants to merge 8 commits into from
Closed

Migrate General section functionality to the app level settings page. #1012

wants to merge 8 commits into from

Conversation

JustinBeBoy
Copy link
Contributor

@JustinBeBoy JustinBeBoy commented Jun 27, 2022 •
edited
Loading

Resolve #994

This PR update general section and model of general section in setting page

Screenshot
111
222

@JustinBeBoy JustinBeBoy marked this pull request as ready for review June 29, 2022 02:42
Sirmorrison
Sirmorrison suggested changes Jun 29, 2022
View reviewed changes
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
@JustinBeBoy
refactor code
3a4e409
@JustinBeBoy
Merge remote-tracking branch 'main/master' into migrate_general_setting
3f11b84 
# Conflicts:
#	ui/values/localizable/en.go
#	ui/values/strings.go
@Sirmorrison
Copy link
Contributor

Sirmorrison commented Jul 14, 2022 •
edited
Loading

the app level security should be accessed from to navigation tab.

image

Sirmorrison
Sirmorrison suggested changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your UI is not correct... it should be like this
image

and not like this
image

notice that the wallets are center aligned and not justified to the edges.

ui/page/wallet_list_page.go Outdated Show resolved Hide resolved
@JustinBeBoy JustinBeBoy mentioned this pull request Aug 6, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sirmorrison Sirmorrison Sirmorrison requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App Level settings general section functionality to the app level settings page.
2 participants
@JustinBeBoy @Sirmorrison