Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi: Update wallet settings page to the latest UI #1007

Merged
merged 22 commits into from
Jul 20, 2022
Merged

Multi: Update wallet settings page to the latest UI #1007

merged 22 commits into from
Jul 20, 2022

Conversation

devchoplife
Copy link
Contributor

@devchoplife devchoplife commented Jun 26, 2022

Closes #987, #1006
This PR updates the wallet settings page to the latest mockup.
Images:
image

image

image

image

image

@devchoplife devchoplife marked this pull request as ready for review June 28, 2022 19:37
ui/page/wallets/wallet_settings_page.go Outdated Show resolved Hide resolved
ui/page/wallets/wallet_settings_page.go Outdated Show resolved Hide resolved
ui/page/wallets/wallet_settings_page.go Outdated Show resolved Hide resolved
ui/page/wallets/wallet_settings_page.go Outdated Show resolved Hide resolved
ui/page/wallets/wallet_settings_page.go Outdated Show resolved Hide resolved
ui/page/wallets/wallet_settings_page.go Outdated Show resolved Hide resolved
@JustinBeBoy
Copy link
Contributor

App crash when cancel change passphrase

image

@devchoplife
Copy link
Contributor Author

App crash when cancel change passphrase

image

I created an issue here #1006

JustinBeBoy
JustinBeBoy previously approved these changes Jul 1, 2022
ui/values/localizable/en.go Outdated Show resolved Hide resolved
@devchoplife devchoplife changed the title Update wallet settings page to the latest UI Multi:Update wallet settings page to the latest UI Jul 8, 2022
@devchoplife devchoplife changed the title Multi:Update wallet settings page to the latest UI Multi: Update wallet settings page to the latest UI Jul 8, 2022
Copy link
Contributor

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that to access the wallet setting page, you have to go through the wallets page.

According to the design, the wallet settings page should be accessed from the more page >> settings option.

image

The wallet page as been deprecated in #1008 however, till this PR is merged, leave the design as it is.. Just move wallet setting to more >>> settings.

ui/page/wallets/wallet_settings_page.go Outdated Show resolved Hide resolved
ui/page/wallets/wallet_settings_page.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the review request
image

you dont need the wallet setting option as added.
the settings is now the new wallet setting.. meaning clicking on the settings option should open the wallet settings page

image

Also, move wallet_settings_page.go file from the info package to the root directory page

ui/page/info/wallet_settings_page.go Outdated Show resolved Hide resolved
@Sirmorrison
Copy link
Contributor

Ok.. the PR looks good so far.

Since we are still on the wallet settings page.. kindly update the UI including the following sections.

image

@Sirmorrison Sirmorrison merged commit 3d9daab into planetdecred:master Jul 20, 2022
@devchoplife devchoplife deleted the wallet_settings branch July 20, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V2 wallet settings update
3 participants