Implemented #511 Receive UI: 2.0 , details are as follows: #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.Modified ReceiveViewController.swift and ReceiveViewController scene of Main.storyboard 2.Added ReceiveAccountListView.swift, ReceiveAccountListCell.swift, ReceiveAccountListCell.xib 3.Modified LocalizedStrings.swift, Localizable.strings in order to add some strings
itswisdomagain
suggested changes
Dec 27, 2019
There was a problem hiding this comment.
I noticed that your icons only have 2x and 3x versions, and may not be the exact/right qualities. The official design assets are here: https://drive.google.com/drive/folders/1wW5UJwFn2JmOTVOYapxMjF08ilLt6VWR
bgptr
suggested changes
Jan 4, 2020
bgptr
suggested changes
Jan 4, 2020
bgptr
suggested changes
Jan 7, 2020
|
I just noticed the |
have resolved! |
macsleven
suggested changes
Jan 15, 2020
|
This PR has been stale for almost a month. This feature is currently being implemented a new PR: #583. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:Receive UI 2.0 #511
1.Modified ReceiveViewController.swift and ReceiveViewController scene of Main.storyboard
2.Added ReceiveAccountListView.swift, ReceiveAccountListCell.swift, ReceiveAccountListCell.xib
3.Modified LocalizedStrings.swift, Localizable.strings in order to add some strings
There are a problem that unsolved:Data Display of Receive UI:2.0, Receive UI:2.0 Need the following data structure：