Privacy UI implementation #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add privacy introduction card to overview page - add 'new' badger on privacy list items under wallet options - add SetupPrivacy page - update list cards design to include divider lines and higher radius
dreacot
reviewed
Jan 14, 2021
| TransactionDetailsDialog(transaction).show(context) | ||
| } | ||
|
|
||
| if (position == itemCount - 1) { |
There was a problem hiding this comment.
Some rows don't have a divider line
There was a problem hiding this comment.
Fixed in recent commit.
| <string name="keep_this_app_opened">Keep this app opened</string> | ||
| <string name="mixer_status_info">Mixer will automatically stop when unmixed balance are fully mixed.</string> | ||
| <string name="check_mixer_status">Check mixer status</string> | ||
| <string name="mixing_elp">Mixing…</string> |
There was a problem hiding this comment.
is this meant to spell mixing_help? or is elp short for something?
There was a problem hiding this comment.
I abbreviated ellipsis as elp.
|
|
||
| val usedCSPPAccounts = wallet.findCSPPAccounts() | ||
| // SwitchPreference(this@AccountMixerActivity, Dcrlibwallet.walletUniqueConfigKey(wallet.id, Dcrlibwallet.AccountMixerMixTxChange), mix_tx_change) |
There was a problem hiding this comment.
remove comment if it's not useful
There was a problem hiding this comment.
It's for a pending feature.
app/src/main/java/com/dcrandroid/activities/AccountMixerActivity.kt
Outdated
Show resolved
Hide resolved
…ebers - add account filter to filter out accounts from account picker
dreacot
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires planetdecred/dcrlibwallet#174