show politeia proposals #503

dreacot · 2020-08-07T13:39:28Z

This PR allows users to;

View Decred politeia proposals
View politeia proposals details
View vote status of politeia proposals
Receive notifications for proposals on (new proposal, vote started, vote finished)

How the notifications work

When the client launches the app for the first time, a sync is initiated and all proposals are fetched, now when next the client launches the app the sync initiates again, and if there are new proposals or changes to the proposals fetched initially, our callback listeners are triggered

We have listeners for onNewProposal, onVoteStarted, and onVoteEnded . When any of the listeners are triggered, it sends the appropriate notification to the client

When the client taps on a particular notification, it takes them to the proposal details page for that particular proposal

Screenshots

app/src/main/java/com/dcrandroid/HomeActivity.kt

app/src/main/java/com/dcrandroid/activities/more/PoliteiaActivity.kt

app/src/main/java/com/dcrandroid/util/NetworkTask.kt

app/src/main/java/com/dcrandroid/util/Utils.kt

app/src/main/res/values-fr/strings.xml

app/src/main/java/com/dcrandroid/data/Constants.java

beansgum · 2020-11-02T12:43:56Z

app/src/main/java/com/dcrandroid/activities/more/PoliteiaActivity.kt

+        currentFragment = PoliteiaFragment()
+        supportFragmentManager
+                .beginTransaction()
+                .replace(R.id.container, currentFragment)
+                .commit()


Why is the activity displaying a single fragment? Move the fragment code to this activity if it's not required.

the code from the activity was moved to a fragment, so the sync function can be accessed from the base fragment

app/src/main/res/layout/fragment_politeia.xml

app/src/main/java/com/dcrandroid/fragments/more/PoliteiaFragment.kt

feat: fetched proposal details from api style: modified some layouts

feat: added approporiate message for proposal status(publishes, abandoned) feat: implemeted politeia from dcrlibwallet

perf: updated proposal status util chore: refined code in proposal class chore: added yes/no votes to proposal details chore: cleaned up code

…oved, rejected and abandoned) proposals feat: added category filter for proposals

…ed localy fetched data

… Vote Ended)

chore: made green background darker so text can be more readeable chore: centered percentage in progress bar

…posal list page

chore: add button to manually sync proposal incase initial sync fails chore: implemented changes requested from PR review

…ices chore: fixed crash occuring on proposal details page

remove unused class members and update variables according to dcrlibwallet

- rotate sync icon while fetching missing proposals - add option to stop sync

dreacot · 2021-01-08T19:54:46Z

app/src/main/java/com/dcrandroid/activities/more/PoliteiaActivity.kt

            }

            override fun onNothingSelected(parent: AdapterView<*>?) {}
        }

        go_back.setOnClickListener {
+            multiWallet!!.politeia.clearSavedProposals()


why does going back clear all fetched proposals?, shouldn't it still remain saved for when next the user needs to access them?

also after going back the first time, entering the proposal page again and going back again crashes the app, because there's no data to be cleared

That was for debugging, will remove it.

dreacot · 2021-01-08T19:59:11Z

app/src/main/java/com/dcrandroid/activities/more/PoliteiaActivity.kt

+            tv_sync_label.setText(R.string.stop_sync)
+
+            if(multiWallet!!.politeia.synced()) {
+                sync_icon.animation = null


tv_sync_label.setText("Synced")

after the sync completes, the text could be changed to disconnect or something similar, so the user can know the sync is done, right now it shows stop sync

Sync doesn't 'complete', what completed is the fetching of all unfetched proposals and dcrlibwallet will continue to check every 30 minutes for proposal updates.

This is why I don't really support that 'Sync' phrase in this part of the app because it's going to be confused with normal syncing.

oh i see, yes it's a bit confusing, we might have to find a suitable synonym

…dary progress

- add proposal title and author name to notifications - allow proposal sync if wallet is not connected

dreacot · 2021-01-26T23:29:47Z

Reviewed and everything looks good

dreacot marked this pull request as ready for review September 1, 2020 22:27

beansgum suggested changes Sep 2, 2020

View reviewed changes

dreacot requested a review from beansgum September 15, 2020 14:59

beansgum suggested changes Nov 2, 2020

View reviewed changes

dreacot added 26 commits January 8, 2021 16:57

feat: added politeia activity

96a5231

feat: added politeia list item

e0bf341

feat: added politeia details activity

4d0c137

refractor: proposal details

1db8832

chore: add proposal datatype

3e5a84b

refractor: proposal details

6bf89de

refractor: proposal details

3b44873

feat: added util to calculate time

e6911a8

feat: fetched proposal details from api style: modified some layouts

chore: removed commented test codes

10cefae

style: added politeia notication settings option to layout file

b3d97eb

chore: added method to register proposal notification

7edc413

chore: modified proposal class

4395488

feat: implemented lazy load

eac522f

feat: added approporiate message for proposal status(publishes, abandoned) feat: implemeted politeia from dcrlibwallet

feat: loaded proposal details and vote status from dcrlibwallet

953f693

perf: updated proposal status util chore: refined code in proposal class chore: added yes/no votes to proposal details chore: cleaned up code

style: made UI improvements

075646c

feat: added functions to fetch (in discussion, active, approved, appr…

4125b13

…oved, rejected and abandoned) proposals feat: added category filter for proposals

fix: corrected vote summary display

c161169

chore: added count for categories

28ecabe

feat: update proposal list and proposals details implementation to us…

9619f6c

…ed localy fetched data

feat : implemented politeia notifications(New Proposal, Vote Started,…

7713e97

… Vote Ended)

feat : open proposal details page when proposal notifcation is clicked

4d13a54

chore: made proposal message clearer

585a5c3

fix: fixed crash that occured when proposal list was empty

178ae6e

chore: added button to share and open proposal in browser

f8b4aba

chore: centered loading page

749f492

chore: made green background darker so text can be more readeable chore: centered percentage in progress bar

chore: added option to sort proposals by timestamp

dc74482

dreacot and others added 19 commits January 8, 2021 16:57

fix: inconsistent padding with spinner and app bar when scrolling pro…

4fd32bc

…posal list page

feat: implemented settings to enable/disable notifications

01a9de5

chore: cleanup code

33a1e22

chore: users can only sync when connected to decred network

59b85ab

chore: add button to manually sync proposal incase initial sync fails chore: implemented changes requested from PR review

chore: fixed issue where sync button wasn't fully showing on some dev…

f6fe166

…ices chore: fixed crash occuring on proposal details page

chore: renamed proposal listeners

501d266

chore: updated notifications listener implementation

18f96c6

fix: blank page when proposal list was empty

d19d299

chore: remove unsed import statements

e2934c5

chore: cleaned up code

c4139e9

chore: removed redundant code for loading proposals

d3e7c10

Remove redundant PoliteiaFragment

293a8cd

Replace java threads with kotlin coroutine

337cdde

politeia: simplify onScrollChanged function

ccffa44

Use constants for proposal categories and simplify when statements

d0c2f90

politeia: remove loading page

49e8203

Cleanup Proposal class

ceb6802

remove unused class members and update variables according to dcrlibwallet

Update notification callbacks

d0a287d

Fix proposal sync

954a354

- rotate sync icon while fetching missing proposals - add option to stop sync

beansgum force-pushed the politeia branch from d954fdb to 954a354 Compare January 8, 2021 15:58

dreacot commented Jan 8, 2021

View reviewed changes

beansgum added 3 commits January 18, 2021 17:57

Fix rejected proposals showing as approved and fix progress bar secon…

c87d733

…dary progress

Cancel all notifications when app is closing

3508f4c

- add proposal title and author name to notifications - allow proposal sync if wallet is not connected

Start syncing proposals 7 seconds after overview is shown

6f922f8

beansgum added 2 commits January 29, 2021 13:48

Merge branch 'master' into politeia

f068be8

Fix syntax error

3b0628a

beansgum approved these changes Jan 29, 2021

View reviewed changes

beansgum merged commit 267da06 into planetdecred:master Jan 29, 2021

dreacot mentioned this pull request Sep 21, 2021

Notification for new politeia votes starting #245

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

show politeia proposals #503

show politeia proposals #503

dreacot commented Aug 7, 2020 •

edited

Loading

beansgum Nov 2, 2020

dreacot Nov 5, 2020

dreacot Jan 8, 2021

beansgum Jan 8, 2021

dreacot Jan 8, 2021

dreacot Jan 8, 2021

beansgum Jan 8, 2021

dreacot Jan 8, 2021

dreacot commented Jan 26, 2021

show politeia proposals #503

show politeia proposals #503

Conversation

dreacot commented Aug 7, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dreacot commented Jan 26, 2021

dreacot commented Aug 7, 2020 •

edited

Loading