-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize directory structure #64
Conversation
fc86de8
to
3761261
Compare
3761261
to
d9f0885
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit👍
I think it's fine to merge as is, but just for suggestion and asking for opinion,
How about flattening prisma/prisma into prisma?
And i think shim-inner naming seems a bit weird, how about renaming prisma/shim to prisma/mod and prisma/shim-inner to prisma/shim?
The reason why it has prisma/prisma is that prisma expects the schema to be at prisma/schema.prisma by default, and it expects the migrations to be inside prisma/migrations, so if we were to support db migration with multiple dbs (sqlite/postgresql) without having to switch provider every single time creating migrations, it might be better off to generate modified prisma schema files inside nested directories (prisma/prisma-sqlite and prisma/prisma-postgresql?). |
I've been thinking about good convention to rename shim-inner.ts, but I couldn't in a while, so I'll merge and keep thinking about it, and if someone or I get a good Idea make a new PR to rename it. |
dev.ts
are located at root..ts
files containing constant values are put toconstant/
.devTools
contains standalone programs useful in development.messages
contains codes related to messaging between components.prisma
encapsules prisma related code (shim, wrapper, etc.).sample
contains sample contract and related stuff.scripts
contains standalone management scripts.utils
contains general utility code.web
contains web dashboard code.closes #24