-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix electron-builder Linux Package Build Failure #2184
Conversation
Akamig
commented
Jun 7, 2023
- Added rpm again.
- Added pacman target because I WANT TO USE ARCH
- I guess fpm would solve everything.
- We needed some dirty trick specified at How to pack the application as RPM/deb format under the ARM64 environment electron-userland/electron-builder#3901 (comment)
- I guess It would work now.
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Fix electron-builder Linux Package Build Failure (cherry picked from commit bdda160)
* Merge pull request #2176 from planetarium/fix/swap-rate-text BA-DA-BOOM (cherry picked from commit c8930fb) * Merge pull request #2184 from planetarium/fix-linux-build Fix electron-builder Linux Package Build Failure (cherry picked from commit bdda160) * Merge pull request #2177 from Atralupus/fix/cache-key-notfound fix: Cache keynotfound error (cherry picked from commit e79655d) * Merge pull request #2178 from Atralupus/ci/cleanup-unpacked ci: Cleanup unpacked dir (cherry picked from commit c0077ec) * Crank up the version up to 0.0.2!!! --------- Co-authored-by: Akamig <[email protected]> Co-authored-by: Kim sm <[email protected]> Co-authored-by: area363 <[email protected]> Co-authored-by: Kidon (Don) Seo <[email protected]> Co-authored-by: Jiwon <[email protected]>
* Merge pull request #2176 from planetarium/fix/swap-rate-text BA-DA-BOOM (cherry picked from commit c8930fb) * Merge pull request #2184 from planetarium/fix-linux-build Fix electron-builder Linux Package Build Failure (cherry picked from commit bdda160) * Merge pull request #2177 from Atralupus/fix/cache-key-notfound fix: Cache keynotfound error (cherry picked from commit e79655d) * Merge pull request #2178 from Atralupus/ci/cleanup-unpacked ci: Cleanup unpacked dir (cherry picked from commit c0077ec) * Crank up the version up to 0.0.2!!! --------- Co-authored-by: Jiwon <[email protected]>