Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Fix broken commit e7cb574 + rewritten loadSettings() and saveSettings() from the QIodeTabWidget class #323

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

alixdamman
Copy link
Collaborator

@alixdamman alixdamman commented Aug 11, 2023

Broken commit is e7cb574

    - merged contextMenuDatabaseTab and contextMenuTextTab into a unique QMenu object contextMenu
    - renamed the slot method saveCurrentTab() as saveTab()
    - renamed the slot method closeCurrentTab() as closeTab()
    - renamed the slot method clearCurrentTab() as clearTab()

fix commit e7cb574 -> the index used when a user called
the Save or Close action from the context menu was actually the index of the current displayed tab.
     - removed struct ReportParams
     - save forceAsText boolean
@alixdamman alixdamman changed the title GUI: Fix previous commit e7cb574bb7e2ebf3c83a817c57389de29fd4b64c + rewritte loadSettings() and saveSettings() from the QIodeTabWidget class GUI: Fix previous commit e7cb574 + rewritte loadSettings() and saveSettings() from the QIodeTabWidget class Aug 11, 2023
@alixdamman alixdamman changed the title GUI: Fix previous commit e7cb574 + rewritte loadSettings() and saveSettings() from the QIodeTabWidget class GUI: Fix broken commit e7cb574 + rewritte loadSettings() and saveSettings() from the QIodeTabWidget class Aug 11, 2023
@alixdamman alixdamman changed the title GUI: Fix broken commit e7cb574 + rewritte loadSettings() and saveSettings() from the QIodeTabWidget class GUI: Fix broken commit e7cb574 + rewritten loadSettings() and saveSettings() from the QIodeTabWidget class Aug 11, 2023
@alixdamman alixdamman merged commit 80a2f36 into master Aug 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant