-
Notifications
You must be signed in to change notification settings - Fork 30
Conversation
Oh, and as mentioned but not addressed in #27, we should really consider embracing a framework because the code is beginning to get unweildly. |
I'd love to see this pulled in. It's actually the one item holding me back from installing. |
Ugh, merge conflicts again? Patching this. One sec =/ |
Alright, pushed. We should prob wait for CI to approve. |
Yay, it's green =) |
Hey, so what exactly should I be seeing for multi-teams? Should I be seeing the side-bar on the left? |
OK, I see it now. Does this need a MAJOR or MINOR version bump? |
This is backwards compatible so minor works fine. |
To fill in what the redacted comment had: The multi-team sidebar will show up once users have logged into multiple teams and restarted the app. It's hard to manage state without an framework so this was the low-tech approach for now. |
OK cool. v1.4.0 is published |
This PR adds back multi team support with the necessary edits to support tray notifications which are now on
master
. The key differences from #27 are:chat-loaded
toteams-loaded
addEventListener
for iframe load listeningSlackWindow
/cc @wlaurance