Skip to content
This repository has been archived by the owner on Nov 2, 2018. It is now read-only.

Added multi team support #30

Merged
merged 1 commit into from
Apr 29, 2015
Merged

Added multi team support #30

merged 1 commit into from
Apr 29, 2015

Conversation

twolfson
Copy link
Member

@twolfson twolfson commented Apr 8, 2015

This PR adds back multi team support with the necessary edits to support tray notifications which are now on master. The key differences from #27 are:

  • Renamed chat-loaded to teams-loaded
  • Added notification handler for count against all windows
  • Moved to addEventListener for iframe load listening
  • Moved notification listener logic into SlackWindow

/cc @wlaurance

@twolfson
Copy link
Member Author

twolfson commented Apr 8, 2015

Oh, and as mentioned but not addressed in #27, we should really consider embracing a framework because the code is beginning to get unweildly.

@andrewelkins
Copy link

I'd love to see this pulled in. It's actually the one item holding me back from installing.

@twolfson
Copy link
Member Author

Ugh, merge conflicts again? Patching this. One sec =/

@twolfson
Copy link
Member Author

Alright, pushed. We should prob wait for CI to approve.

@twolfson
Copy link
Member Author

Yay, it's green =)

@wlaurance
Copy link
Contributor

Hey, so what exactly should I be seeing for multi-teams? Should I be seeing the side-bar on the left?

@twolfson
Copy link
Member Author

Whoops wrong screenshot. Please don't share that one -_-;;

selection_123

@wlaurance
Copy link
Contributor

OK, I see it now.

Does this need a MAJOR or MINOR version bump?

@twolfson
Copy link
Member Author

This is backwards compatible so minor works fine.

wlaurance added a commit that referenced this pull request Apr 29, 2015
@wlaurance wlaurance merged commit f18cb09 into plaidchat:master Apr 29, 2015
@twolfson
Copy link
Member Author

To fill in what the redacted comment had:

The multi-team sidebar will show up once users have logged into multiple teams and restarted the app.

It's hard to manage state without an framework so this was the low-tech approach for now.

@wlaurance
Copy link
Contributor

OK cool. v1.4.0 is published

@twolfson twolfson deleted the dev/multi.team.sqwished branch April 30, 2015 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants