feat: add use_frameworks support #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 tasks
dtroupe-plaid
approved these changes
Aug 22, 2024
|
@WoLewicki Thanks for updating - What's the urgency to get a release out with this? |
|
If you have time to do a release I am up for doing them ASAP. Both those PRs should be ready for merging and releasing already 🚀 Would be nice to have people test those for sure 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR concerning New Architecture support in the library 🎉
We at Software Mansion have been working on improving support for the new architecture for quite a while now. If you need help with anything related to New Architecture, like:
or you just want to ask any questions, hit us up on [email protected]
Summary
Add support for
use_frameworksflag, similar to how it is done inmapbox: https://github.com/rnmapbox/maps/blob/e5b1ca5326f08009010d108d0b30e7269efd0859/rnmapbox-maps.podspec#L266-L268 and https://github.com/rnmapbox/maps/blob/e5b1ca5326f08009010d108d0b30e7269efd0859/ios/RNMBX/rnmapbox_maps-Swift.pre.h#L10-L14