Control flow clarifications/simplifications (and partly minor optimisations/fixes) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since $encoding is initialised to `identity` and only possibly assigned one of the values of the `for` loop, it can never have a value other than `gzip`, `deflate`, or `identity`.
At this point, $encoding can never have a value other than `gzip` or `deflate`, so this condition will always be true.
Since we are assigning to $encoder unconditionally, it is obviously silly to then check if we have an $encoder.
We always return a response, just not always an encoded one. All we really check for is, does the client accept one of the encodings we make, or does it not. So it is pointless to scan for the `identity` encoding: it is simply among the encodings we do not make.
The `ref` function handle undefined input and always produces a defined output so it is a waste of time to work up to the final check by testing each component subexpression first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin.
I also have another inessential commit on top of this branch: a983e2e — Should I add it to this branch/PR?