Skip to content

Commit

Permalink
diffReveiw: more verbose aria label for header
Browse files Browse the repository at this point in the history
  • Loading branch information
isidorn committed Mar 20, 2020
1 parent 37865c4 commit 4aac842
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/vs/editor/browser/widget/diffReview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -590,11 +590,11 @@ export class DiffReview extends Disposable {

const getAriaLines = (lines: number) => {
if (lines === 0) {
return nls.localize('no_lines', "no lines");
return nls.localize('no_lines_changed', "no lines changed");
} else if (lines === 1) {
return nls.localize('one_line', "1 line");
return nls.localize('one_line_changed', "1 line changed");
} else {
return nls.localize('more_lines', "{0} lines", lines);
return nls.localize('more_lines_changed', "{0} lines changed", lines);
}
};

Expand All @@ -608,9 +608,9 @@ export class DiffReview extends Disposable {
'That encodes that at original line 154 (which is now line 159), 12 lines were removed/changed with 39 lines.',
'Variables 0 and 1 refer to the diff index out of total number of diffs.',
'Variables 2 and 4 will be numbers (a line number).',
'Variables 3 and 5 will be "no lines", "1 line" or "X lines", localized separately.'
'Variables 3 and 5 will be "no lines changed", "1 line changed" or "X lines changed", localized separately.'
]
}, "Difference {0} of {1}: original {2}, {3}, modified {4}, {5}", (diffIndex + 1), this._diffs.length, minOriginalLine, originalChangedLinesCntAria, minModifiedLine, modifiedChangedLinesCntAria));
}, "Difference {0} of {1}: original line {2}, {3}, modified line {4}, {5}", (diffIndex + 1), this._diffs.length, minOriginalLine, originalChangedLinesCntAria, minModifiedLine, modifiedChangedLinesCntAria));
header.appendChild(cell);

// @@ -504,7 +517,7 @@
Expand Down

0 comments on commit 4aac842

Please sign in to comment.