run for windows #16
Open
run for windows #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeskells
force-pushed
the
runOnWindows
branch
from
ccc3fb8 to
a9eef0a
Compare
pkukielka
reviewed
Sep 10, 2018
run.py
Outdated
| @@ -63,19 +65,32 @@ def findFiles(path, regex): | |||
| def call_compiler(scalaLocation, output, additionalScalacOptions, additionalConfig=[]): | |||
| agentJar = os.path.join(".", "umad", "target", "umad-1.0-SNAPSHOT.jar") | |||
| configOverrides = map(lambda v: "-J-D" + v, options.config + additionalConfig) | |||
| with open('params.txt', 'w') as params: | |||
There was a problem hiding this comment.
Maybe something like this for less duplication?
paramsList = [configOverrides, scalacOptions, sources, debugOptions, additionalScalacOptions]
with open('params.txt', 'w') as paramsFile:
for params in paramsList:
for param in params:
paramsFile.write(param + "\n")
pkukielka
reviewed
Sep 10, 2018
run.py
Outdated
| @@ -63,19 +65,32 @@ def findFiles(path, regex): | |||
| def call_compiler(scalaLocation, output, additionalScalacOptions, additionalConfig=[]): | |||
| agentJar = os.path.join(".", "umad", "target", "umad-1.0-SNAPSHOT.jar") | |||
| configOverrides = map(lambda v: "-J-D" + v, options.config + additionalConfig) | |||
| with open('params.txt', 'w') as params: | |||
There was a problem hiding this comment.
Can we put this file somewhere in tmp dir instead of project dir?
mkeskells
force-pushed
the
runOnWindows
branch
from
a9eef0a to
a4b85d1
Compare
.cmd and .bat files need suffix
mkeskells
force-pushed
the
runOnWindows
branch
from
a4b85d1 to
df096fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running with windows cmd you need to specify the extensions .cmd/.bat
write the params to file to reduce the command length