Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#10444 Improve dialog component design #87

Merged
merged 3 commits into from
Nov 17, 2024
+3 −4
Merged

pkp/pkp-lib#10444 Improve dialog component design #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23bad13
pkp/pkp-lib#10444 Fix URL for managing static page in plugins listing
blesildaramirez Oct 8, 2024
37f6375
pkp/pkp-lib#10444 Add modalStyle when using dialog component
blesildaramirez Oct 8, 2024
2baf08f
pkp/pkp-lib#10444 remove modalStyle param when using AjaxModal class
blesildaramirez Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion StaticPagesPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ public function getActions($request, $actionArgs)
null,
'management',
'settings',
'website',
['website'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bug when managing a static page item. It couldn't build the URL for the link action for the item because it expects the $path param to be an array.

['uid' => uniqid()], // Force reload
'staticPages' // Anchor for tab
)),
Expand Down
1 change: 0 additions & 1 deletion controllers/grid/StaticPageGridHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ public function initialize($request, $args = null)
new AjaxModal(
$router->url($request, null, null, 'addStaticPage'),
__('plugins.generic.staticPages.addStaticPage'),
'modal_add_item'
),
__('plugins.generic.staticPages.addStaticPage'),
'add_item'
Expand Down
4 changes: 2 additions & 2 deletions controllers/grid/StaticPageGridRow.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public function initialize($request, $template = null)
new AjaxModal(
$router->url($request, null, null, 'editStaticPage', null, ['staticPageId' => $staticPageId]),
__('grid.action.edit'),
'modal_edit',
null,
true
),
__('grid.action.edit'),
Expand All @@ -63,7 +63,7 @@ public function initialize($request, $template = null)
__('common.confirmDelete'),
__('grid.action.delete'),
$router->url($request, null, null, 'delete', null, ['staticPageId' => $staticPageId]),
'modal_delete'
'negative'
),
__('grid.action.delete'),
'delete'
Expand Down