Skip to content

Commit

Permalink
pkp/pkp-lib#10444 Improve dialog component design (#87)
Browse files Browse the repository at this point in the history
* pkp/pkp-lib#10444 Fix URL for managing static page in plugins listing

* pkp/pkp-lib#10444 Add modalStyle when using dialog component

* pkp/pkp-lib#10444 remove modalStyle param when using AjaxModal class
  • Loading branch information
blesildaramirez authored Nov 17, 2024
1 parent 17be34c commit a66ed2b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion StaticPagesPlugin.php
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ public function getActions($request, $actionArgs)
null,
'management',
'settings',
'website',
['website'],
['uid' => uniqid()], // Force reload
'staticPages' // Anchor for tab
)),
Expand Down
1 change: 0 additions & 1 deletion controllers/grid/StaticPageGridHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ public function initialize($request, $args = null)
new AjaxModal(
$router->url($request, null, null, 'addStaticPage'),
__('plugins.generic.staticPages.addStaticPage'),
'modal_add_item'
),
__('plugins.generic.staticPages.addStaticPage'),
'add_item'
Expand Down
4 changes: 2 additions & 2 deletions controllers/grid/StaticPageGridRow.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public function initialize($request, $template = null)
new AjaxModal(
$router->url($request, null, null, 'editStaticPage', null, ['staticPageId' => $staticPageId]),
__('grid.action.edit'),
'modal_edit',
null,
true
),
__('grid.action.edit'),
Expand All @@ -63,7 +63,7 @@ public function initialize($request, $template = null)
__('common.confirmDelete'),
__('grid.action.delete'),
$router->url($request, null, null, 'delete', null, ['staticPageId' => $staticPageId]),
'modal_delete'
'negative'
),
__('grid.action.delete'),
'delete'
Expand Down

0 comments on commit a66ed2b

Please sign in to comment.