[pkp-lib] #3261 review assignments export #3722
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmecher
reviewed
May 25, 2018
| function assignAssocTypeAndIdToFile($fileId, $assocType, $assocId) { | ||
| // Update the file in the database. | ||
| $this->update( | ||
| 'UPDATE submission_files |
There was a problem hiding this comment.
Beware that this will set the assoc information for all revisions. Is that intentional?
asmecher
reviewed
May 25, 2018
| * @param $reviewId integer | ||
| * @return array | ||
| */ | ||
| function getByReviewId($reviewId) { |
There was a problem hiding this comment.
The getBy convention generally returns an object of the DAO's newDataObject function's return type. Since you're returning IDs here, I'd suggest renaming the function.
asmecher
reviewed
May 25, 2018
| * @return string | ||
| */ | ||
| function getPluralElementName() { | ||
| return 'review assignments'; |
There was a problem hiding this comment.
I don't think this is expected where it's called to include spaces. See lib/pkp/plugins/importexport/native/filter/NativeImportFilter.inc.php.
asmecher
reviewed
May 25, 2018
| * @return string | ||
| */ | ||
| function getSingularElementName() { | ||
| return 'review assignment'; |
asmecher
reviewed
May 25, 2018
| * @return string | ||
| */ | ||
| function getPluralElementName() { | ||
| return 'review rounds'; |
There was a problem hiding this comment.
(as commented before, also below)
asmecher
reviewed
May 25, 2018
| foreach ($submissionFileDoc->documentElement->childNodes as $childNode) { | ||
| if (!is_a($childNode, 'DOMElement')) continue; | ||
| if ($childNode->tagName == 'revision') $revisionNode = $childNode; | ||
| if ($submissionFileDoc) { |
There was a problem hiding this comment.
Should there be an else with an error condition?
defstat
force-pushed
the
i3261-reviewAssignments-export
branch
from
4924cd3
to
bc3930b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.