Error while upgrading to OJS 3.4 if the journal's URL/domain has been changed

[jonasraoni]

Describe the bug
At the I8508_ConvertCurrentLogFile migration, the error below happens if the config.inc.php isn't using the production URL.

Error: File /files/usageStats/usageEventLogs/usage_events_20240319.log could not be successfully converted.

1. As a sysadmin, I might decide to upgrade the system under a temporary host, and this error is unexpected to me and tough to reason about.
   Just a warning like ensure you've got the right base_url before migrating might not be enough, so I think we can be more pro-active and attempt to convert the file at this point (at least a couple of lines to ensure that it's ok):
   

   pkp-lib/classes/migration/upgrade/v3_4_0/PreflightCheckMigration.php

   Line 206 in 3db74ed

   // check if there are usage stats log files older than yesterday

2. As the code has a couple of continues, I think it's better to ensure that at least one entry really failed before assuming that the file couldn't be processed (e.g. if the file just has one entry, an internal apache request then the tool will not process anything and mistakenly assume that it failed).

To Reproduce

1. Setup a different base_url
2. Attempt to upgrade with a pending log file at the {$files_dir}/usageStats/usageEventLogs
3. See error

What application are you using?
OJS 3.4

PRs:
stable-3_4_0:

• pkp/pkp-lib#9810 check if the URL in the usage stats log file corresp… #10152
• pkp/pkp-lib#9810 submodule update ##bozana/9810-3_4_0## ojs#4348 (only submodule update)
• pkp/pkp-lib#9810 submodule update ##bozana/9810-3_4_0## omp#1623 (only submodule update)
• pkp/pkp-lib#9810 submodule update ##bozana/9810-3_4_0## ops#723 (only submodule update)

main:

• pkp/pkp-lib#9810 check if the URL in the usage stats log file corresp… #10182

[jonasraoni]

@bozana check if it makes sense what I wrote.

[bozana]

Hi @jonasraoni,

1. Yes, the right URL is needed, because we extract the context path, page, operation, args from the URL. For this we first remove the base URL (s. https://github.com/pkp/pkp-lib/blob/stable-3_4_0/classes/cliTool/traits/ConvertLogFile.php#L320).
   And, yes, maybe we can improve the preflight check. It will need some code, but...
2. Currently we expect at least one line to be successfully converted in order to see the conversion as successful. I think this is OK/correct, because we would not need to create an empty new file. We could eventually track if error occurs and in case it does not occur, we can display a different message, e.g. that the new file does not contain any entries so it is not created. But, I think this case is (almost) not possible to happen, thus this should have very low priority.

[jonasraoni]

1. We had this issue on a large installation, I did some workarounds to not restart from beginning, but a standard user wouldn't have this option. Also, it was difficult to understand why exactly it failed, I had to debug the code.

2. I also think it's unlikely to happen, I just saw that the possibility exists and wanted to warn :)

[bozana]

@jonasraoni, could you please review the PR above?
Thanks a lot!