Address the execution of scheduled tasks and jobs

[jonasraoni]

Describe the bug

• The php tools/runScheduledTasks.php runs scheduled tasks AND jobs.
• The php lib/pkp/tools/jobs.php run runs only jobs.

Therefore, the execution of scheduled tasks ends up shadowing the usage of the job runner. After skimming the code, looks like the scheduled task PKP\task\ProcessQueueJobs will run all the queued jobs (which might be too resource intensive).

Solution

• The long-term solution will probably be coded at Replace task scheduler by Laravel scheduler #9678
• I think it might make sense to keep the php tools/runScheduledTasks.php as it is, doing everything. It will save less skilled users (that won't upgrade the system properly/deal with sysadmin details).
• As it's tough to call the runScheduledTasks.php frequently inside the job runner (e.g. when using the worker mode, it would probably require dispatching a job that dispatches itself, which is risky if not done properly), then I think a configuration to control whether the runScheduledTasks.php will also run jobs is enough. This will allow skilled users to run the scheduled tasks and jobs separately.

What application are you using?
OJS 3.4

[jonasraoni]

@touhidurabir You can take a look at this one as well. I think the job_runner setting should also control the execution of jobs at the runScheduledTasks.php, so that's what I did.

[touhidurabir]

@jonasraoni I approve the changes. even though that was not our initial thought as we want to people move away from job runner as mush as possible but I see the advantage of allowing it run through when running it via cron even when it's disable . This will allow to utilize the job runner with defined constrains through cron even when it's turn off for application request life cycle .

[jonasraoni]

Thanks, so I'll merge!

tl;dr:
job_runner = on: The job execution is managed by the application, jobs will be executed together with the scheduled tasks.
job_runner = off: The job execution is fully offloaded to the sysadmin (jobs.php).