Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OJS/master: creating new versions and publishing not working as expected #5160

Closed
ajnyga opened this issue Oct 16, 2019 · 3 comments
Closed

Comments

@ajnyga
Copy link
Collaborator

ajnyga commented Oct 16, 2019

Describe the bug
In latest master branch, publishing and creating new errors causes some javascript related errors where the workflow screen is not updated as expected. Most likely a problem in the workflowcontainer.vue

To Reproduce
Steps to reproduce the behavior:

  1. As journal editor or site admin or any other role capable of publishing go the publication tab
  2. Click on Publish: error message "You are not authorized to access the requested resource." appears and the create a new version button does not become visible. It will become visible if you manually refresh the page.
  3. Click on "Createa new version" button. The publication tab will get stuck while trying to reload. Refreshing the whole page shows that a new version has been created.

Submission stage does not seem to affect this.

What application are you using?
OJS master branch

@ajnyga
Copy link
Collaborator Author

ajnyga commented Oct 17, 2019

The "you are not authorized" message comes after publishing and is the result of a call to:
api/v1/issues/undefined?_=1571316691702

Note that the issueId is missing in the API call. So thinking that the issueId is not passed here: https://github.com/pkp/ui-library/blob/master/src/components/Container/WorkflowContainerOJS.vue#L21

@NateWr
Copy link
Contributor

NateWr commented Oct 22, 2019

This may be part of the little bugs here: #5122 (comment). I'll try to reproduce after that gets merged.

@NateWr
Copy link
Contributor

NateWr commented Oct 23, 2019

PR:
pkp/ui-library#46

Tests:
pkp/ojs#2514

NateWr added a commit to pkp/ui-library that referenced this issue Oct 23, 2019
pkp/pkp-lib#5160 Fix dropped data during publishing process in workflow
@NateWr NateWr closed this as completed Oct 23, 2019
henriqueramos pushed a commit to henriqueramos/ui-library that referenced this issue Jan 20, 2022
henriqueramos pushed a commit to henriqueramos/ui-library that referenced this issue Jan 20, 2022
pkp/pkp-lib#5160 Fix dropped data during publishing process in workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants