Fix issue cover image size in default theme #4705
Assignees
Labels
Bug:1:Low
A bug that does not have a severe consequence or affects a small number of users.
Milestone
Comments
NateWr
added
the
Bug:1:Low
|
Hi @NateWr, PR here: pkp/ojs#2397 |
|
Thanks @thinkbulecount2! Merged. |
|
It looks like we missed the styles for desktop when we restored the cover image styles. See: https://forum.pkp.sfu.ca/t/manuscript-child-theme-issue-cover-is-too-big/52758/6 The styles that need to be restored are here: pkp/ojs@fa16697#diff-20b130338b52d8575cb07eafd972d63aL90-L141 They should be applied to media queries larger than |
|
PR: pkp/ojs#2518 cc: @NateWr |
NateWr
added a commit
to pkp/ojs
that referenced
this issue
Oct 25, 2019
pkp/pkp-lib#4705 Put code back to fix cover image issue
yammut
added a commit
to yammut/ojs
that referenced
this issue
Oct 29, 2019
* pkp/pkp-lib#5021 Restore subscription grid search options * Complete es_ES locale for CrossRef plugin Added missing translations for es_ES locale. * pkp/pkp-lib#5023 Fix obsolete constant name * Address Github security warnings * pkp/pkp-lib#5015 Changed lang attribute for local keys * pkp/pkp-lib#5015 Removed extra quotation mark * Update copyright date * fix typo in ru_RU locale * Submodule update * pkp/pkp-lib#5029 Bump PHP baseline to PHP7.2 * Bump citationStyleLanguage baseline to PHP7.2 * pkp/pkp-lib#5029 Submodule update ##asmecher/i5029-fix## * pkp/pkp-lib#5029 Disable PHP7.1 Travis tests * Complete API es_ES locales Added all missing texts for es_ES in api.xml * Submodule update * Minor fixes (proposals) Updated to september 4, 2019 * sl_SI-3_1_2_update * Correct XML path for validation * pkp/pkp-lib#2072 Working prototype of versioning based on new publication entity This commit includes all of the initial work done to support versioning based on a split between submissions and publications. All submission data related to publication, such as title, abstract, citations, authors and galleys, has been moved to a new publication entity. Submissions have a "one to many" relationship to Publications. Each Submission may have one or more Publications attached to it. Each Publication is treated as a new version. Published version data can not be modified. - New publication entity split from submissions - New API endpoints for publications - Workflow UI changes to support versions (publications) - Pre-publication validation checks - New STATUS_SCHEDULED for publications scheduled for publication in a future issue - Deprecated many methods on the Submission object - Upgrade scripts written from 3.1.x. - Tests updated to work, except for issue import. Some code is commented out or has not been updated yet. Progress on remaining support for versioning will be tracked in Github. See: https://github.com/pkp/pkp-lib/projects/15 * pkp/pkp-lib#2072 Fix whitespace and typo errors * pkp/pkp-lib#2072 Fix conflict with citation style language in template variable name * pkp/pkp-lib#2072 Fix tests * pkp/pkp-lib#2072 Drop temporary table during upgrade * Submodule update ##NateWr/i2072_versioning## * pkp/pkp-lib#2072 Fix fatal error when previewing article not assigned to issue * Submodule update * pkp/pkp-lib#5057 Update MEDRA dev endpoint URL * pkp/pkp-lib#5055 Fix author dashboard * Submodule update * Submodule update * pkp/pkp-lib#5068 Cast sequences to integers * Submodule update * Submodule update * Submodule update * Update ru_RU locale after pkp#2457 * allow gateway plugins to add authorization policies * Permit correct storage of section ID on initial insert * Submodule update * pkp/pkp-lib#5017 Include submission subtitle in Crossref XML * Submodule update * pkp/pkp-lib#4325 include affiliations for all authors * Remove unused variable * Recompile JS * pkp/pkp-lib#4989 Add defaultReviewMode setting on upgrade * Remove dead code * Submodule update * pkp/pkp-lib#5047 Don't allow galleys to be added or edited in published publications * Submodule update ##NateWr/i5047_galley_edit## * pkp/pkp-lib#5045 Restore keywords variables to article details template * Update pt_BR REVISED_VERSION_NOTIFY email template * pkp/pkp-lib#5089 fix variable test for section editor count * pkp/pkp-lib#4870 Support versioning on article landing page * Submodule update ##NateWr/i4870_reader_versioning## * pkp/pkp-lib#5087 Don't show category selection if no categories exist * pkp/pkp-lib#3386 Add new EditorialActionsHandler to minified scripts * Submodule update ##NateWr/i3386_editorial_actions## * Code syntax tweak * pkp/pkp-lib#4906 Remove OAI dependency on published_submissions * Revert 979337f * pkp/pkp-lib#5103 Remove sexist language * pkp/immersion#25 Move language-specific text into locale files * pkp/immersion#25 Fix test language (on disabled test) * pkp/immersion#25 Fix test language * Correct typo * pkp/pkp-lib#5044 Add date published field to journal entry form - Change date_published column from datetime to date - Remove unused publicationType and publicationDateType properties * Submodule update ##NateWr/i5044_date_published## * pkp/pkp-lib#5046 Add unpublish button to versions * pkp/pkp-lib#4779 Move to using XLIFF files for translation (work in progress) * pkp/pkp-lib#4779 Remove translator plugin * pkp/pkp-lib#4779 Adapt to PO files instead of XLIFF * pkp/pkp-lib#4779 Convert selected locales to PO * pkp/pkp-lib#4779 Submodule update ##asmecher/po## * pkp/pkp-lib#4779 Convert selected plugin locale files to PO * pkp/pkp-lib#4779 Submodule update * pkp/pkp-lib#4779 Convert pt_BR to PO format * Submodule update * Submodule update * pkp/pkp-lib#5045 Indicate publishing schedule in publish confirmation message * pkp/pkp-lib#5045 Use correct phrase for pre-publication tests * Submodule update ##NateWr/i5045_publish_message## * pkp/pkp-lib#5043 Add upgrade script to fix bad submission status * pkp/pkp-lib#4857 Fix schedule for publication button and move locale string to shared library * Submodule update ##NateWr/i4857_open_tab## * pkp/pkp-lib#4873 Fix dependent file handling for versioning - Deletes dependent files when galley deleted - Checks if file is used by a previous version before deleting * Submodule update ##NateWr/i4873_files## * Update ru_RU locale after PR pkp#2478 * Update ru_RU locale after PR pkp#2481 * pkp/pkp-lib#4859 Fix searching with addition of versioning * Submodule update * pkp/pkp-lib#5098 Update workflow template with changes to data * pkp/pkp-lib#5098 Update workflow handler with changes from pkp-lib * pkp/pkp-lib#5098 Fix tests * Submodule update ##NateWr/i5098_performance## * pkp/pkp-lib#5044 Use locale string from shared library * Submodule update ##NateWr/i5044_scheduled## * pkp/pkp-lib#4861 Migrates cover images to support versioning - Combines coverImage and coverImageAltText settings into one - Migrates settings to publication_settings table - Updates article landing page to show correct publication cover image * Submodule update ##NateWr/i4861_covers## * pkp/pkp-lib#5138 Fix capitalization of class name * pkp/pkp-lib#5139 Fix custom block manager plugin; remove extraneous code * Submodule update * Submodule update * pkp/pkp-lib#1375 Permit null issue Number and Year values * Clean up PHP warnings * Resolve count erroroneous call on DAOResultFactory * pkp/pkp-lib#5122 Support Iterator pattern for DAOResultFactories * pkp/pkp-lib#5122 Use Iterator pattern in search indexing * pkp/pkp-lib#4880 Properly skip XML import test (to avoid missing publication database inconsistency from broken import code) * pkp/pkp-lib#5122 Code review tweak * pkp/pkp-lib#5122 Scrutinizer tweaks * Submodule update * Submodule update * Submodule update * pkp/pkp-lib#5122 Facilitate the use of Iterators in service classes * pkp/pkp-lib#4859 Add metadata indexing to publication service * pkp/immersion#25 Tweak for fr_FR abbreviation * pkp/pkp-lib#4867 Initial work adding DOIs to publications * pkp/pkp-lib#4867 Add DOI preview to publish form * pkp/pkp-lib#4905 Restore support for exporting pub ids and metadata * Submodule update ##NateWr/i4867_dois## * Forward-port ae7c745 to master branch * Submodule update * pkp/pkp-lib#4804 Fix self-join problem on CrossRef upgrade SQL * pkp/pkp-lib#4924 Properly display access status for pay-per-view purchases * Fix filename typo * pkp/pkp-lib#4593 Fix incorrect access indications in category listing * Submodule update * Update ru_RU locale after PR pkp#2496 * Submodule update * Forward-port fr_CA emailTemplates.xml to master * pkp/pkp-lib#4168 Migrate submission date_status_modified to last_activity * pkp/pkp-lib#4168 Document new daysInactive API param * Submodule update ##NateWr/i4168_last_activity## * include two new email templates * two new email templates * two new email templates * two new email templates * two new email templates * two new email templates * two new email templates * two new email templates * pkp/pkp-lib#4867 Migrate DOI settings on upgrade * Add issue querybuilder filter for issue ids to support browsebysection plugin * Fix filter by section parameters in querybuilder * Fix conditional check on empty array in issue query builder * Submodule update * pkp/pkp-lib#5122 Fix check for empty DAOResultIterator and change naming pattern * pkp/pkp-lib#5122 Use Countable interface in DAOResultIterator * Submodule update * Fix PHP warnings/errors * pkp/pkp-lib#5216 Update links to in-app help * Add missing ID fetch * updated fr_CA translation * pkp/pkp-lib#5122 Update naming pattern when returning an iterator * Submodule update ##NateWr/i5122_iterator## * Submodule update: in-app help * pkp/pkp-lib#5526 Add missing templates in other languages during upgrade * pkp/pkp-lib#4705 Put code back to fix cover image issue * pkp/pkp-lib#5208 Update URN plugin to support publications - Adds FieldUrn component - Makes the check number generation available in more places - Updates plugin setting names * pkp/pkp-lib#5208 Remove extra whitespace * Submodule update ##NateWr/i5208_urn## * pkp/pkp-lib#4705 Fixed spacing * pkp/pkp-lib#4705 Removed spaces * pkp/pkp-lib#5011 Forward-port to master * Update ru_RU locale after PR pkp#2519 * Fix subject search * pkp/pkp-lib#4684 Added mobile nav menu for smaller screens * Replaced pkp_site_name in body.less to remove default 100% width * pkp/pkp-lib#4684 HTML adjustments for default theme mobile nav menu * pkp/pkp-lib#4684 Added close symbol to open mobile nav menu * pkp/pkp-lib#4684 Renamed classes * pkp/pkp-lib#4684 Toggle nav menu dropdowns on small/large screens * pkp/pkp-lib#4684 Moved .pkp_nav_list class to a media query * Moved .pkp_nav_list out of helpers, so deleting it * pkp/pkp-lib#4684 Fixed mobile nav styles, added two search bars * pkp/pkp-lib#4684 CSS for two menu bars WIP * pkp/pkp-lib#4684 Fixed what is showing and what is not in search bars * pkp/pkp-lib#4684 Styling mobile search bar * pkp/pkp-lib#4684 Added separate search form for mobile * pkp/pkp-lib#4684 Work out layout/design issues with mobile nav in default theme * pkp/pkp-lib#4684 Remove unused search form template * pkp/pkp-lib#4684 Improve style of task count in nav menus * pkp/pkp-lib#4684 Fix inaccessible user nav item due to lost hover * pkp/pkp-lib#4684 Fix mobile nav menu widths from phone to tablet size * pkp/pkp-lib#4684 Remove mobile user nav styles on large screens * pkp/pkp-lib#4684 Restore animated search styles in default theme header * pkp/pkp-lib#4684 Fix search form class and mobile nav padding * Submodule update ##NateWr/i4684_nav_menu##
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The styles for the issue cover image were changed in a commit for 3.1.2 (pkp/ojs@fa16697#diff-20b130338b52d8575cb07eafd972d63a), and the size of the issue cover image is no longer restricted. (Reported)
They were probably removed by accident while cleaning up other
.coverstyles, and should probably just be restored.The text was updated successfully, but these errors were encountered: