Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined variable when retrieving submission by status #4604

Closed
ptrckb opened this issue Mar 14, 2019 · 2 comments
Closed

Undefined variable when retrieving submission by status #4604

ptrckb opened this issue Mar 14, 2019 · 2 comments

Comments

@ptrckb
Copy link
Contributor

ptrckb commented Mar 14, 2019

With OJS 3.1.1, using SubmissionDAO's getByStatus() triggers an error for an undefined variable in getSearchWhere().

629e7ec introduced the helper function but failed to rename one occurence of an old variable ($search -> $phrase).

This has already been fixed as part of 32d50e1 in 'stable-3_1_2' and 'master'.

ptrckb added a commit to ptrckb/pkp-lib that referenced this issue Mar 14, 2019
ptrckb added a commit to ptrckb/ojs that referenced this issue Mar 14, 2019
@ptrckb
Copy link
Contributor Author

ptrckb commented Mar 14, 2019

pkp-lib: #4605
ojs: pkp/ojs#2330

asmecher added a commit that referenced this issue Mar 15, 2019
asmecher added a commit to pkp/ojs that referenced this issue Mar 15, 2019
pkp/pkp-lib#4604 Submodule update ##ptrckb/submissiondao-undefined-va…
@asmecher
Copy link
Member

Thanks, @ptrckb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants