Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support categories in default theme #4446

Closed
NateWr opened this issue Feb 7, 2019 · 3 comments
Closed

Support categories in default theme #4446

NateWr opened this issue Feb 7, 2019 · 3 comments
Assignees
@NateWr
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Milestone
OJS/OMP 3.1.2

Comments

@NateWr
Copy link
Contributor

NateWr commented Feb 7, 2019

#4158 introduced categories and browsing by categories to OJS. Our default theme should style these pages. Ideally, all of our themes will support this, but at the very least our default theme should with 3.1.2.

Sorry to chuck this into 3.1.2 so late, @asmecher, but it just occurred to me.
@NateWr NateWr added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Feb 7, 2019
@NateWr NateWr added this to the OJS/OMP 3.1.2 milestone Feb 7, 2019
@NateWr NateWr mentioned this issue Feb 7, 2019
Closed
@NateWr NateWr self-assigned this Feb 7, 2019
NateWr added a commit to NateWr/pkp-lib that referenced this issue Feb 7, 2019
@NateWr
pkp#4446 Adjust category locale strings and move app-specific strings…
bba8440 
… out of pkp-lib
NateWr added a commit to NateWr/ojs that referenced this issue Feb 7, 2019
@NateWr
pkp/pkp-lib#4446 Improve appearance of category pages on the frontend
b9f1fd4
NateWr added a commit to NateWr/omp that referenced this issue Feb 7, 2019
@NateWr
pkp/pkp-lib#4446 Adjust category pages to reflect shared pkp-lib assets
b5ae261
NateWr added a commit to NateWr/pkp-lib that referenced this issue Feb 7, 2019
@NateWr
pkp#4446 Adjust category locale strings and move app-specific strings…
039ff6f 
… out of pkp-lib
NateWr added a commit to NateWr/omp that referenced this issue Feb 7, 2019
@NateWr
pkp/pkp-lib#4446 Adjust category pages to reflect shared pkp-lib assets
05dcdad
NateWr added a commit to NateWr/ojs that referenced this issue Feb 7, 2019
@NateWr
pkp/pkp-lib#4446 Improve appearance of category pages on the frontend
b8e441e
@NateWr
Copy link
Contributor Author

NateWr commented Feb 7, 2019

PRs (master):
#4453
pkp/ojs#2275
pkp/omp#632

PRs (3.1.2):
#4454
pkp/ojs#2276
pkp/omp#633

@NateWr NateWr mentioned this issue Feb 7, 2019
Closed
NateWr added a commit to NateWr/pkp-lib that referenced this issue Feb 12, 2019
@NateWr
pkp#4446 Adjust category locale strings and move app-specific strings…
c97b7ff 
… out of pkp-lib
NateWr added a commit to NateWr/ojs that referenced this issue Feb 12, 2019
@NateWr
pkp/pkp-lib#4446 Improve appearance of category pages on the frontend
63b5ebe
NateWr added a commit to NateWr/pkp-lib that referenced this issue Feb 12, 2019
@NateWr
pkp#4446 Adjust category locale strings and move app-specific strings…
2cdfdde 
… out of pkp-lib
NateWr added a commit to NateWr/ojs that referenced this issue Feb 12, 2019
@NateWr
pkp/pkp-lib#4446 Improve appearance of category pages on the frontend
fce36b6
NateWr added a commit to NateWr/omp that referenced this issue Feb 12, 2019
@NateWr
pkp/pkp-lib#4446 Adjust category pages to reflect shared pkp-lib assets
54c19b3
NateWr added a commit to NateWr/omp that referenced this issue Feb 12, 2019
@NateWr
pkp/pkp-lib#4446 Adjust category pages to reflect shared pkp-lib assets
36c6032
NateWr added a commit to NateWr/pkp-lib that referenced this issue Feb 26, 2019
@NateWr
pkp#4446 Adjust category locale strings and move app-specific strings…
b193df5 
… out of pkp-lib
NateWr added a commit to NateWr/pkp-lib that referenced this issue Feb 26, 2019
@NateWr
pkp#4446 Load app locale keys for catalog handler
bc84509
NateWr added a commit to NateWr/ojs that referenced this issue Feb 26, 2019
@NateWr
pkp/pkp-lib#4446 Improve appearance of category pages on the frontend
fa16697
NateWr added a commit to NateWr/pkp-lib that referenced this issue Feb 26, 2019
@NateWr
pkp#4446 Adjust category locale strings and move app-specific strings…
cecd2c7 
… out of pkp-lib
NateWr added a commit to NateWr/pkp-lib that referenced this issue Feb 26, 2019
@NateWr
pkp#4446 Load app locale keys for catalog handler
d120907
NateWr added a commit to NateWr/ojs that referenced this issue Feb 26, 2019
@NateWr
pkp/pkp-lib#4446 Improve appearance of category pages on the frontend
a3e16f0
NateWr added a commit to NateWr/omp that referenced this issue Feb 26, 2019
@NateWr
pkp/pkp-lib#4446 Adjust category pages to reflect shared pkp-lib assets
5027c3c
NateWr added a commit to NateWr/omp that referenced this issue Feb 26, 2019
@NateWr
pkp/pkp-lib#4446 Adjust category pages to reflect shared pkp-lib assets
23a2d46
NateWr added a commit to pkp/omp that referenced this issue Feb 27, 2019
@NateWr
Merge pull request #632 from NateWr/i4446_categories
a6327a1 
 pkp/pkp-lib#4446 Adjust category pages to reflect shared pkp-lib assets
NateWr added a commit that referenced this issue Feb 27, 2019
@NateWr
Merge pull request #4454 from NateWr/i4446_stable
69154e3 
STABLE: #4446 Adjust category locale strings and move app-specific…
NateWr added a commit that referenced this issue Feb 27, 2019
@NateWr
Merge pull request #4453 from NateWr/i4446_categories
0ed05e2 
#4446 Adjust category locale strings and move app-specific…
NateWr added a commit to pkp/ojs that referenced this issue Feb 27, 2019
@NateWr
Merge pull request #2276 from NateWr/i4446_stable
eaf69d3 
STABLE: pkp/pkp-lib#4446 Improve appearance of category pages on the frontend
NateWr added a commit to pkp/ojs that referenced this issue Feb 27, 2019
@NateWr
Merge pull request #2275 from NateWr/i4446_categories
fa7e36f 
 pkp/pkp-lib#4446 Improve appearance of category pages on the frontend
NateWr added a commit to pkp/omp that referenced this issue Feb 27, 2019
@NateWr
Merge pull request #633 from NateWr/i4446_stable
1c19d3b 
Stable:  pkp/pkp-lib#4446 Adjust category pages to reflect shared pkp-lib assets
@NateWr
Copy link
Contributor Author

NateWr commented Feb 27, 2019

Finally, tests passing, no merge conflicts. Thanks for the assist on the OMP tests, @asmecher. Merged.

@NateWr NateWr closed this as completed Feb 27, 2019
@asmecher
Copy link
Member

Woo!

@NateWr NateWr mentioned this issue Mar 4, 2019
Open
@tgc tgc mentioned this issue Jul 5, 2019
Closed
tgc added a commit to tgc/omp that referenced this issue Jul 5, 2019
@tgc
pkp/pkp-lib#4901 Missing translation key
97140a1 
Key was renamed in pkp/pkp-lib#4446.
tgc added a commit to tgc/pkp-lib that referenced this issue Jul 10, 2019
@tgc
pkp#4901 Missing translation key
5dddab9 
Key was renamed in pkp#4446.
@tgc tgc mentioned this issue Jul 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NateWr NateWr

Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
None yet
Milestone
OJS/OMP 3.1.2
Development

No branches or pull requests
2 participants
@asmecher @NateWr