pkp/pkp-lib#5122 Facilitate the use of Iterators in service classes #2491
Conversation
| foreach ($submissions as $submission) { | ||
| if ($submission->getSubmissionProgress() == 0) { // Not incomplete | ||
| $this->submissionMetadataChanged($submission); | ||
| $this->submissionFilesChanged($submission); |
There was a problem hiding this comment.
Not sure, but should this only include published submissions? If so, you can add a status property to the getMany call:
Services::get('submission')->getMany(['contextId' => $journal->getId(), 'status' => STATUS_PUBLISHED]);
There was a problem hiding this comment.
Depends on our indexing strategy -- there's value in indexing unpublished content if we don't re-index fully on publication, which may be the case. This needs an audit/clean-up -- I'll do a small assessment as part of this issue and invariably leave some for pkp/pkp-lib#3180 as well.
| $templateMgr = TemplateManager::getManager($request); | ||
| if ($this->_articleGalley) $templateMgr->assign(array( | ||
| 'representationId' => $this->_articleGalley->getId(), | ||
| 'articleGalley' => $this->_articleGalley, | ||
| 'articleGalleyFile' => $this->_articleGalley->getFile(), | ||
| )); | ||
| $journal = $request->getJournal(); |
There was a problem hiding this comment.
$context = $request->getContext(); :)
There was a problem hiding this comment.
Just juggling already-existing code, but yes, fixed!
package.json
Outdated
| "less-loader": "^4.1.0", | ||
| "lint-staged": "^8.1.6", | ||
| "lint-staged": "^8.2.1", |
There was a problem hiding this comment.
There are a lot of version bumps here. Usually when I run an update like this, I do some manual checking to try to identify any regressions... We also need to keep the versions here in sync with the version in the UI Library.
So I'd suggest either not including these changes in a commit (I'm happy to run an update whenever if you'd like) or making sure that the same changes happen in UI Library and doing some testing on it...
There was a problem hiding this comment.
OK, happy to remove these!
asmecher
force-pushed
the
5122-fix
branch
2 times, most recently
from
08acb5a
to
4a45120
Compare
…ication database inconsistency from broken import code)
No description provided.