Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#9525 Include affiliation/ROR in Crossref deposit #46

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ewhanson
Copy link
Collaborator

@ewhanson ewhanson commented Apr 3, 2024

No description provided.

@ewhanson
Copy link
Collaborator Author

ewhanson commented Apr 3, 2024

@bozana, I've been investigating adding in support for pulling in the ROR even when the ROR plugin isn't installed (for example in the current main branch or 3.4), and I've run into an issue. By default, the Author object will only have properties that are part of its schema, so if the ROR plugin isn't present (or doesn't exist) to add the rorId author field to the author schema, then even if it's saved in the database, it will never be loaded into the application.

Do you think this is something that should be addressed now or is it best to add in the bare-bones support now so that when the ROR plugin is present, it will work. As of right now, with this approach, it will only work in 3.3.

Thanks!

@bozana
Copy link
Contributor

bozana commented Apr 8, 2024

@ewhanson, oh... Hmm... Yes, maybe we can prepare that part of the code, so that it is there once we have a solution for it (either updating the ROR plugin to 3.4 and 3.5, or integrating it into the core (which I think would be better)). It can then be that 3.4 will never work, but... :-
We can maybe speak about it tomorrow in the meeting... :-)
Thanks a lot!

@ewhanson
Copy link
Collaborator Author

ewhanson commented Apr 8, 2024

Thanks, @bozana, that sounds good!

@klausru
Copy link

klausru commented Apr 24, 2024

Dear @bozana and @ewhanson
thanks for your suggestion, which I think is useful and feasible. I asked for the delivery of affiliations already in 2022.
However, in OJS 3.3 only Crossref scheme 4.3.6. is supported. Your code relies on Crossref scheme 5+. See changes: https://www.crossref.org/documentation/schema-library/metadata-deposit-schema-5-3-1/
I am convinced that we should try to deliver as much data as possible, including translated titles, abstracts etc. and having this feature backward compatible, at least for OJS 3.2/3.3

Do you happen to have updated working code for OJS 3.3 ? I would be happy to test and to contribute.

All the best
Klaus

@bozana
Copy link
Contributor

bozana commented Apr 29, 2024

Hi @klausru,
@ewhanson is currently working on it -- it will be provided for the next release 3.3.1...

@bolelligallevi
Copy link
Contributor

Hi @bozana, from the release archive it looks like 3.3.1 has to come...
We have OJS 3.3.0.13 and ROR plugin 1.0.0.12 and no affiliation (textual or ROR) is exported to crossref...
Do you know when 3.3.1 will be released or when affiliations will be included in data exported to crossref?
Best regards
Stefano

@bozana
Copy link
Contributor

bozana commented Oct 7, 2024

Hi @bolelligallevi, I don't know when release 3.3.1 would come. Most of the team members are currently away, at the developer sprint, but I will make a note for myself to ask them next week when they return back, and will then let you know...

@bolelligallevi
Copy link
Contributor

Hi @bozana, thanks for your answer, it's ok to wait after the sprint. In the meanwhile, can you confirm that "affiliations included in data exported to crossref" is a featured planned for 3.3.1? It is already included in 3.4? Best regards

@bozana
Copy link
Contributor

bozana commented Oct 14, 2024

Hi @bolelligallevi, the changes (to include affiliation into the crossref export) will come with this issue: pkp/pkp-lib#9525. So you can follow that issue, to see when the changes are merged for which release.
@ewhanson has started to work on it and it seems the work is pretty finished for OJS 3.3 and main branch, but for 3.4 and OPS the pull requests/changes are still to come.
I will maybe ping @ewhanson to ask if he could maybe continue to work on it -- it is not much left, I think. (And I still have to double check with the team about 3.3.1 release.)

@bolelligallevi
Copy link
Contributor

Hi @bozana, thanks for your update, I met @ewhanson in Turin and I mentioned the affiliations in crossdref issue with him, so I hope he will continue to work on it.
I started following pkp/pkp-lib#9525 and I think it could be usefull that @klausru would follow too, if he's not already doing.
Best regards
Stefano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants