Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Category support #138

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Category support #138

merged 1 commit into from
Nov 13, 2019

Conversation

dennmuel
Copy link
Contributor

Adds basic support for categories, fixes #106

NateWr
NateWr suggested changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@NateWr NateWr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @dennmuel! I've added just a couple comments.

templates/frontend/pages/catalogCategory.tpl Outdated Show resolved Hide resolved
templates/frontend/pages/catalogCategory.tpl Outdated Show resolved Hide resolved
@dennmuel dennmuel requested a review from NateWr November 12, 2019 15:51
@dennmuel
Copy link
Contributor Author

Thanks @NateWr, I updated accordingly.

NateWr
NateWr suggested changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@NateWr NateWr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've loaded it up to see what it looks like myself and had just one suggested change to align it with Bootstrap's components and to fix some HTML syntax.

templates/frontend/pages/catalogCategory.tpl Show resolved Hide resolved
@dennmuel dennmuel requested a review from NateWr November 13, 2019 11:13
@NateWr NateWr merged commit 8733b3e into pkp:3.1.2 Nov 13, 2019
@dennmuel dennmuel deleted the categories branch November 13, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NateWr NateWr Awaiting requested review from NateWr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennmuel @NateWr